Add boolean switch in the ini file and list parameters to turn on or off application of sensing/actuation filter compensation
It is helpful and useful to have the analog and compensation for both actuation and sensing in the parameter file so that we can ask questions and plot transfer functions even of the compensated components.
For example, in the [sensing]
section, we have listed
omc_meas_z_whitening_higain =
omc_meas_p_whitening_higain = 10389.66, 11030.14, 11054.70: 10305.19, 11095.39, 11119.01
omc_meas_z_whitening_logain =
omc_meas_p_whitening_logain = 10160.01, 11177.81, 11180.64: 10627.50, 10919.74, 10932.76
omc_meas_z_trans_amplifier =
omc_meas_p_trans_amplifier = 11.08e3, 10.220e3: 11.16e3, 10.17e3
omc_compensation_filter_file = Common/H1CalFilterArchive/h1omc/H1OMC_1336944438.txt
omc_compensation_filter_bank = OMC_DCPD_A, OMC_DCPD_B
omc_compensation_filter_modules_in_use =
omc_compensation_filter_gain = 1,1
which manifests in the DARM loop model as though it is already compensated by the front-end. Currently, if you populate the in-band and super-Nyquist analog zeros and poles, one must also populate the compensation section with all of the in-band filter modules.
To accomplish this, we want to expand the parameter key-value pairs to have values listed (but unused unless compensation_on = False
).
omc_meas_z_whitening_higain_compensated = ...
omc_meas_p_whitening_higain_compensated = ...
omc_meas_z_whitening_logain_compensated = ...
omc_meas_p_whitening_logain_compensated = ...
omc_meas_z_whitening_higain_super_nyquist =
omc_meas_p_whitening_higain_super_nyquist = 10389.66, 11030.14, 11054.70: 10305.19, 11095.39, 11119.01
omc_meas_z_whitening_logain_super_nyquist =
omc_meas_p_whitening_logain_super_nyquist = 10160.01, 11177.81, 11180.64: 10627.50, 10919.74, 10932.76
omc_meas_z_trans_amplifier_compensated = ...
omc_meas_p_trans_amplifier_compensated = ...
omc_meas_z_trans_amplifier_super_nyquist =
omc_meas_p_trans_amplifier_super_nyquist = 11.08e3, 10.220e3: 11.16e3, 10.17e3
omc_compensation_filter_file = Common/H1CalFilterArchive/h1omc/H1OMC_1336944438.txt
omc_compensation_filter_bank = OMC_DCPD_A, OMC_DCPD_B
omc_compensation_filter_modules_in_use = ...
omc_compensation_filter_gain = 1,1
compensation_on = True (this turns off the zeros and poles listed in "_compensated" and turns off the "filter_modules_in_use", and assumes the front end is doing this instead of us calculating it in the DARM model)
Same is true for the coil drivers in the actuation side as well.
Jeff suggests that it would be helpful to have the method that computes the transfer functions have an argument that turns on or off the compensation that is accessible outside of the ini file.
Blocks !101 (merged) that is addressing #74 (closed)
See also #109 (closed) so that sensing and actuation have consistency in style in methods, consider dictionaries