pSEOBNRv4HM_tgr-review.md

+Collect material for the review of the QNM test using the EOB framework (temporary page soon to be moved in the TGR namespace).  
+
+**Telecons minutes**  
+
+*19/06/2019*  
+
+*Attendees*  
+
+Abhirup, Gregorio, Max, Roland  
+
+*Minutes*  
+
+- Abhirup gave a review-readiness presentation.  
+- The code has been recently rebased on master (12 June), so the branch is quite up-to-date.  
+- In the non-spinning model omega_nGR := omega_GR*(1+domega) was sampled over, 
+ but in this implementation priors would be a problem when combining multiple events with different priors.  
+- The nonspinning model will switch to the domega sampling before starting the review.  
+- Spinning model samples on all GR parameters plus (domega,dtau) for each mode.  
+- Flat priors on domega and dtau.  
+
+
+*Code changes brief description*  
+
+- The commits:  
+
+• https://git.ligo.org/abhirup.ghosh/lalsuite/commit/806042d6677db73ef000246a519ba93b48aaf67f  
+• https://git.ligo.org/abhirup.ghosh/lalsuite/commit/12e9ac666684aab4a5282fdee348e46ab73a6af5  
+
+perform the implementation. While:  
+
+• https://git.ligo.org/abhirup.ghosh/lalsuite/commit/cec6dc437facbe6902741d0af874c2a2abc9060f  
+• https://git.ligo.org/abhirup.ghosh/lalsuite/commit/97bbac2de3c5974c66858a8b815f2dae332a53e0   
+ 
+polish the code.  
+
+- Added to lalinference a general option called qnmtestparameters to handle parameters addition and priors, similar to grtestparameters in parametrized tests.  
+- In lalsimulation: change the function that computes the qnm spectrum.  
+- Edited cbcpostproc.py to post-process the additional parameters, add params in hdf5 files, etc.   
+
+*Conclusions and future plans* 
+
+- Agreement to start the review right away and try to be ready for the publication timeline.  
+ Short-term goal is to have first results by the time of GR22.  
+- Agreement on reviewing first the spinning version, then the non-spinning version.  
+- Meet in ~1 week after a broad look to the code, to come up with a proposal for a set of injections to test the code and split the different files to be checked.  
+
+*Action items*  
+
+- Abhirup to ask Richard about issues (in the older non-spinning implementation) with the ringdown attachment when leaving the whole omega_GR*(1+domega) free.  
+Why doesn't it happen anymore?   
+
+- Abhirup to create:  
+1. Corner plots with (Mf,af,domega)   
+2. A plot showing (Mf,af) from a GR run vs the ones recovered when domega was varying.  
+(These plots are to check that a deviation in Mf does not compensate a deviation in domega in such a way that omega(Mf,af)*(1+domega) still matches the GR prediction)   
\ No newline at end of file