| ... | ... | @@ -32,6 +32,32 @@ Collect material for the review of the QNM test using the EOB framework (tempora |
|
|
|
|
|
|
|
To run the test, please add MISSING to the config file and MISSING.
|
|
|
|
|
|
|
|
**Points to be addressed**
|
|
|
|
|
|
|
|
- Priors: currently hardcoded. Is this final? What is the standard for TIGER params?
|
|
|
|
- Sampling: how can I sample on a subset of all QNM-test parameters? Should they be fixed? Is this the way TIGER tests are performed?
|
|
|
|
- An UNUSED function is being edited:
|
|
|
|
|
|
|
|
@@ -1057,6 +1067,22 @@ static UNUSED INT4 XLALSimIMREOBAttachFitRingdown(XLAL_ERROR(XLAL_EFUNC)
|
|
|
|
|
|
|
|
Is it truly unused?
|
|
|
|
- Why this line?
|
|
|
|
|
|
|
|
- if (use_hm) {
|
|
|
|
+ if (use_hm && 0) {
|
|
|
|
|
|
|
|
- Why do you declare them as unused?
|
|
|
|
|
|
|
|
+ UNUSED REAL8 domega220 = XLALSimInspiralWaveformParamsLookupDOmega220(LALparams);
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
**Description of the changes**
|
|
|
|
|
|
|
|
- The code takes as input SEOBNRv4HM and edits the QNM complex frequencies.
|
|
|
|
- The waveform is built by sampling on all the standard GR parameters and adding parametrised deviations to the real frequency and damping time. Post-merger amplitudes and phases are retained from GR.
|
|
|
|
- Attachment: MISSING description
|
|
|
|
|
|
|
|
**Presentations**
|
|
|
|
|
| ... | ... | |
