The purpose of this MR is to generate a new opt
module for handling optimisation.
Charlie Hoy (284dbd2e) at 27 Mar 22:29
pass lambda1 to new wvf interface
The purpose of this MR is to pass the tidal parameters to the waveform generation. cc @jocelyn-read
Charlie Hoy (64eb707f) at 27 Mar 22:00
add tidal parameters to waveform generation
... and 2 more commits
When you submit chi_p=0 in trigger parameters, you get chi_p SNR of nan
The purpose of this MR is to prevent NaN
's in peak SNRs when chi_p = 0
. This fixes #8.
ping @geraint.pratten.
The purpose of this MR is to prevent NaN
's in peak SNRs when chi_p = 0
. This fixes #8.
glue.ligolw
is deprecated (see lscsoft/glue@e3e68217) and will be removed in a future release of lscsoft-glue. All code should be updated to use the new interface provided by python-ligo-lw.
The usage of glue.ligolw
in this package is contained within the simple_pe.localization.sky
module, which apparently I wrote >10 years ago, but I can't see any usage of that module in the rest of the package. Can that just be removed?
I believe this was fixed in !149 (merged). I am therefore closing this issue.
@ben.patterson, thank you for raising this issue. Can you provide an example so I can reproduce and attempt to debug this error please?