Yeah, this looks good and is hopefully easily extendable.
Resume files aren't transferred with condor_rm, but they should be if there's another kind of failure.
These files should be covered (for dynesty) with these lines.
@jacob.golomb I think this just needs a rebase and then we can merge.
Since this needs a rebase, can we collapse these two lines together, just do the following?
result.posterior = likelihood.conversion_function(result.posterior)[0]
Colm Talbot (7d23f095) at 18 Mar 16:33
Colm Talbot (c23324e4) at 18 Mar 16:33
BUG: fix how found injections are read
Colm Talbot (7d23f095) at 18 Mar 16:24
TYPO: readd accidentally deleted code
Colm Talbot (86bd7fc3) at 18 Mar 16:21
TYPO: switch to in place booleans
The following discussion from !1322 should be addressed:
I'm not sure why this would be failing for Python 3.9 and not 3.10, but I noticed we don't explicitly install
lalsuite
. Could that be part of the issue?
This was resolved by !1340 (merged)
!1299 has broken one of the pymc examples that imports that Pymc
sampler directly.
This MR just fixes the import.
Colm Talbot (2b93355c) at 18 Mar 15:28
BUG: fix import of Pymc in example
@michael.williams can we start by copying the code currently in asimov to here? That way we can integrate it to our test suite. That should make things easier when we want to make changes.
I think it would be this file and this file, and tests?
Where do you think documentation on how to use bilby_pipe via asimov should live?