From 5f2ad8e72cead1badb40c1ed20fedfaebed39264 Mon Sep 17 00:00:00 2001
From: Tanner Prestegard <tanner.prestegard@ligo.org>
Date: Thu, 15 Nov 2018 14:28:04 -0600
Subject: [PATCH] Remove userprofile URLs for which views just return a 404
URLs for editing contacts and notifications were defined, but the
view functions just returned 404 responses. So what's the point
in having them at all?
---
gracedb/templates/profile/notifications.html | 2 --
gracedb/userprofile/urls.py | 6 +++---
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/gracedb/templates/profile/notifications.html b/gracedb/templates/profile/notifications.html
index 504ecf7e3..ccc949b10 100644
--- a/gracedb/templates/profile/notifications.html
+++ b/gracedb/templates/profile/notifications.html
@@ -18,7 +18,6 @@
{% for contact in contacts %}
<ul>
<li>
- <!-- <a href="{% url "userprofile-edit-contact" contact.id %}">Edit</a> -->
<a href="{% url "userprofile-test-contact" contact.id %}">Test</a>
<a href="{% url "userprofile-delete-contact" contact.id %}">Delete</a>
{% comment %}
@@ -53,7 +52,6 @@
{% for trigger in triggers %}
<ul>
<li>
- <!-- <a href="{% url "userprofile-edit" trigger.id %}">Edit</a> -->
<a href="{% url "userprofile-delete" trigger.id %}">Delete</a>
{{ trigger.userlessDisplay }}
</li>
diff --git a/gracedb/userprofile/urls.py b/gracedb/userprofile/urls.py
index 733089920..2d1911a5c 100644
--- a/gracedb/userprofile/urls.py
+++ b/gracedb/userprofile/urls.py
@@ -14,14 +14,14 @@ urlpatterns = [
name="userprofile-delete-contact"),
url(r'^contact/test/(?P<id>[\d]+)$', views.testContact,
name="userprofile-test-contact"),
- url(r'^contact/edit/(?P<id>[\d]+)$', views.editContact,
- name="userprofile-edit-contact"),
+ #url(r'^contact/edit/(?P<id>[\d]+)$', views.editContact,
+ # name="userprofile-edit-contact"),
# /options/trigger/
url(r'^trigger/create$', views.create, name="userprofile-create"),
url(r'^trigger/delete/(?P<id>[\d]+)$', views.delete,
name="userprofile-delete"),
- url(r'^trigger/edit/(?P<id>[\d]+)$', views.edit, name="userprofile-edit"),
+ #url(r'^trigger/edit/(?P<id>[\d]+)$', views.edit, name="userprofile-edit"),
# /options/manage_password
url(r'^manage_password$', views.managePassword,
--
GitLab