From 695eae51f9935b7ed2addbc2c70da3fedf21d00c Mon Sep 17 00:00:00 2001
From: Tanner Prestegard <tanner.prestegard@ligo.org>
Date: Wed, 14 Nov 2018 10:59:50 -0600
Subject: [PATCH] Remove web event-voevent view
A weird web view for processing GET (!) parameters and running
buildVOEvent exists in the events app. I can't believe this is
still ever used and it should not be used in favor of the API.
So I am removing it!
---
gracedb/events/urls.py | 7 -------
gracedb/events/views.py | 22 ----------------------
2 files changed, 29 deletions(-)
diff --git a/gracedb/events/urls.py b/gracedb/events/urls.py
index 5642c2e51..6a71152a4 100644
--- a/gracedb/events/urls.py
+++ b/gracedb/events/urls.py
@@ -15,9 +15,6 @@ urlpatterns = [
# Event detail page
url(r'^(?P<graceid>[GEHMT]\d+)/view/$', views.view, name="view"),
- # Event VOEvent creation page
- url(r'^(?P<graceid>[GEHMT]\d+)/voevent/$', views.voevent, name="voevent"),
-
# Event file list and file download
url(r'^(?P<graceid>[GEHMT]\d+)/files/$', views.file_list,
name="file_list"),
@@ -56,10 +53,6 @@ urlpatterns = [
url(r'^view/(?P<graceid>[GEHMT]\d+)', views.view, name="legacyview"),
url(r'^(?P<graceid>[GEHMT]\d+)$', views.view, name="legacyview2"),
- # VOEvent creation
- url(r'^voevent/(?P<graceid>[GEHMT]\d+)', views.voevent,
- name="legacyvoevent"),
-
# Neighbors
url((r'^neighbors/(?P<graceid>[GEHMT]\d+)/\(?(?P<delta1>[-+]?\d+)'
'(,(?P<delta2>[-+]?\d+)\)?)?'), views.neighbors,
diff --git a/gracedb/events/views.py b/gracedb/events/views.py
index 3c9da215f..ff7d555f5 100644
--- a/gracedb/events/views.py
+++ b/gracedb/events/views.py
@@ -134,28 +134,6 @@ def index(request):
return render(request, 'gracedb/index.html', context=context)
-@event_and_auth_required
-def voevent(request, event):
- # Default VOEvent type is 'preliminary'
- voevent_type=request.GET.get('voevent_type', 'preliminary')
- internal=request.GET.get('internal', 1)
- try:
- # Tanner (10/25/2016): need to modify this call to buildVOEvent,
- # second argument should be a serial_number.
- voevent = buildVOEvent(event, voevent_type=voevent_type,
- request=request, internal=internal)
-
- # Issue alert
- EventVOEventAlertIssuer(voevent, alert_type='voevent').issue_alerts()
- # Exceptions caused by user errors of some sort.
- except VOEventBuilderException, e:
- return HttpResponseBadRequest(str(e))
- # All other exceptions return 500.
- except Exception, e:
- return HttpResponseServerError(str(e))
-
- return HttpResponse(voevent, content_type="application/xml")
-
def create(request):
d = _create(request)
if isinstance(d, HttpResponse):
--
GitLab