diff --git a/gracedb/api.py b/gracedb/api.py index 556e6bab40ec711ae69821429758979031845916..4fc78387275d97ba2576c9337d9648f93d25d273 100644 --- a/gracedb/api.py +++ b/gracedb/api.py @@ -5,6 +5,7 @@ from django.http import HttpResponseBadRequest, HttpResponseRedirect from django.core.urlresolvers import reverse as django_reverse from django.conf import settings +from django.utils.http import urlquote import json @@ -775,8 +776,9 @@ def eventLogToDict(log, request=None): args=[log.event.graceid(), log.N], request=request) if log.filename: + filename = urlquote(log.filename) file_uri = reverse("files", - args=[log.event.graceid(), log.filename], + args=[log.event.graceid(), filename], request=request) return { diff --git a/templates/gracedb/event_detail.html b/templates/gracedb/event_detail.html index 8e6dee6935a4ce1888d915cdfc2f1664e0155aa3..3338a177159bc20120ede5fa9713b2b42131c85b 100644 --- a/templates/gracedb/event_detail.html +++ b/templates/gracedb/event_detail.html @@ -53,13 +53,13 @@ dc += ' <td> \n'; dc += ' <table class="figures"> \n'; dc += ' <tr class="figrow"> \n'; - dc += ' <td> <a href="{{ log.fileurl }}" dojoType="dojox.image.LightboxNano"><img height="180" src="{{ log.fileurl }}"></a> \n'; + dc += ' <td> <a href="{{ log.fileurl|urlencode }}" dojoType="dojox.image.LightboxNano"><img height="180" src="{{ log.fileurl|urlencode }}"></a> \n'; dc += ' </td> \n'; dc += ' </tr> \n'; dc += ' <tr> \n'; dc += ' <td> {{log.comment|sanitize|escapejs}} \n'; {% if log.fileurl %} - dc += ' <a href="{{log.fileurl}}">{{log.filename}}.</a> \n'; + dc += ' <a href="{{log.fileurl|urlencode}}">{{log.filename}}.</a> \n'; {% endif %} dc += ' Submitted by {{log.issuer}} on {{log.created}} \n'; dc += ' </td> \n'; @@ -92,7 +92,7 @@ dc += ' <td>{{log.issuer.first_name}} {{log.issuer.last_name}}</td> \n'; dc += ' <td>{{log.comment|sanitize|escapejs}} \n'; {% if log.fileurl %} - dc += ' <a href="{{log.fileurl}}">{{log.filename}}</a> \n'; + dc += ' <a href="{{log.fileurl|urlencode}}">{{log.filename}}</a> \n'; {% endif %} dc += ' </td> \n'; dc += ' </tr> \n'; @@ -156,12 +156,12 @@ ret += ' {{log.comment|sanitize|escapejs}} \n'; {% if log.fileurl %} - ret += ' <a href="{{log.fileurl}}">{{log.filename}}</a> \n'; + ret += ' <a href="{{log.fileurl|urlencode}}">{{log.filename}}</a> \n'; {% endif %} ret += ' </td> \n'; ret += ' <td> \n'; {% if log.hasImage %} - ret += ' <a href="{{ log.fileurl }}" dojoType="dojox.image.LightboxNano"><img height="60" src="{{ log.fileurl }}"></a> \n'; + ret += ' <a href="{{ log.fileurl|urlencode }}" dojoType="dojox.image.LightboxNano"><img height="60" src="{{ log.fileurl|urlencode }}"></a> \n'; {% endif %} ret += ' </td> \n'; ret += ' </tr> \n';