Daniel Williams (1f5aee99) at 28 Mar 11:07
That's a good question without (currently) a good answer. I think I need to take this as an action to update this once I have a final understanding of how post-processing is working in 0.6, and have better documented it. This should be soon, but needn't hold up this MR. (Though we should probably pin the asimov requirement to being for `<0.6`
A cautionary note, this (`PESummaryPipeline`) will move in v0.6.0 in a non-backwards compatible way (though I'd like to try and figure out a way to do it without breaking things, and if I can I will).
This isn't an argument against this, but something to keep in mind for the future.
In 0.7.0 it will be removed entirely.
I think, in the long-run, it would be best to do this the other way around, and document the interface in the bilby docs. However, for now I think this is fine. I'll open an asimov issue to resolve this down the line as part of a broader push to sort out all of the pipeline interfaces.
In v0.6-preview review status updates are not being saved to the ledger correctly.
And the same for other CamelCased or underscored keys.
Please change needs_settings
to needs settings
to maintain consistency with other keys in the ledger.
Please change "InterestStatus" to "interest status" to maintain consistency with other keys in the ledger.
Could these be implemented more elegantly as a getter and setter?
We've discussed before whether this behaviour should be in the main asimov codebase as opposed to being specified in your own pipeline implementations. While I'm in favour of the latter, I'll allow this to be added for the moment.
However, please update keys such as needs_settings
to needs settings
to maintain consistency with the style of other keys in the asimov ledger.
What is this for?