Hi Dan,
This issue relates to file:/src/pop_models/astro_models/gw_ifo_vt, and the function 'optimal_snr'
Could you update the optimal_snr function to allow cosmo as an argument, with a default of None, like the psd and approximant?
Then it can use Planck15 as a default cosmology, with no backwards compatibility issues.
Thanks, Vera
Merged!
The pipeline did fail, but that's not due to any of your changes. I created an issue (#8) to look further into this.
Our unit tests are failing to run, seemingly because of some upstream changes to the Docker image it runs on.
I just made two minor changes to make the code installable and run able with updated version of astropy. Because, I was not able to run or even install with older version of astropy. Now, this code runs with latest astropy version.
I just made two minor changes to make the code installable and run able with updated version of astropy. Because, I was not able to run or even install with older version of astropy. Now, this code runs with latest astropy version.
@daniel.wysocki I have made those changes, you may review them now.
Sure, I will make those changes today and will update you.
@muhammad.zeeshan These changes look good. However, while we're replacing numpy.bool -> bool
, there's a few other places it shows up, so we might as well get them all. Could you replace the other instances? Here's a search that shows them
https://git.ligo.org/search?search=numpy.bool&nav_source=navbar&project_id=1190&search_code=true&repository_ref=master
I just made two minor changes to make the code installable and run able with updated version of astropy. Because, I was not able to run or even install with older version of astropy. Now, this code runs with latest astropy version.
Daniel Wysocki (204f3d65) at 11 Sep 21:08
Fixing PPD script for pre-sampled populations
Daniel Wysocki (9aca8591) at 20 Jun 17:01
More stable serialization of pre-sampled populations
Daniel Wysocki (43457077) at 25 Aug 15:48
Fixing but in PreSampledPopulationFamily
Daniel Wysocki (9d5c6b47) at 05 Aug 12:43
Adding missing field
Daniel Wysocki (23f58587) at 02 Jul 02:12
Adding support for multiple VT calibrations
Error message in log_posterior call
File "plot_gaussian_population_with_selectbias_grid.py", line 335, in <module>
args=[], kwargs={},
ValueError: too many values to unpack (expected 2)