GitLab

Introduction of 'offline' parameter

See merge request !16

Adding offline boolean parameter to specify whether event was identified by an online or offline pipeline

Create event with labels

See merge request !15

Make safe_netrc class compatible with old versions of Python

See merge request !12

In older versions of Python, the `netrc.netrc._parse` class took fewer
arguments. Luckily, we are not using any of the additional arguments,
so we can just pass through any `*args` and `**kwargs`.

Check permissions on netrc file

See merge request !11

The netrc.netrc class from the Python standard library applies access
safety checks (requiring that the netrc file is readable only by the
current user, and not by group members or other users) only if using the
netrc file in the default location (~/.netrc). This subclass applies the
same access safety checks regardless of the path to the netrc file.

Update dependencies

See merge request !9

Catch exceptions in logging handler thread

See merge request !8

Remove unused (but confusing) member variable

See merge request !7

Remove dangerous 'except Exception' blocks

See merge request !6

The package does not use M2Crypto or cjson at all, but it does use six.

If writeLog() fails, then print a message to stderr and keep
going. This is one rare circumstance where we must catch all
exceptions. If the logging thread crashes, then it will stop
clearing out the queue. Safe and rapid termination of the
thread requires that we ignore exceptions and continue
consuming items from the queue.

These catch-all exception handlers are a menace. Their only function
is to make it impossible to obtain a stack trace.

Fix some race conditions and corner cases in GraceDb log handler cleanup.

This fixes this exception:

    >>> from ligo.gracedb.rest import GraceDb
    >>> GraceDb().logs("G268556").json()
    Traceback (most recent call last):
      File "<stdin>", line 1, in <module>
      File "/Users/lpsinger/local/lib/python2.7/site-packages/ligo/gracedb/rest.py", line 338, in <lambda>
        response.json = lambda: self.load_json_or_die(response)
      File "/Users/lpsinger/local/lib/python2.7/site-packages/ligo/gracedb/rest.py", line 400, in load_json_or_die
        response_content = response_content.decode()
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 219924: ordinal not in range(128)

Do not call sys.exit in ligo.gracedb.rest module

See merge request !3

The ligo.gracedb.rest module should raise exceptions instead of calling
sys.exit() so that it is possible to inspect stack traces. Generally,
methods in importable modules should not call sys.exit(), just as C
library functions should not call exit().

This change turns output_and_die into a class method that can be
overridden in the classes in the ligo.gracedb.cli module. However,
ideally we should get rid of the output_and_die method altogether,
raise ordinary exceptions in ligo.gracedb.rest, and handle user-friendly
rendering of errro messages in ligo.gracedb.cli.

Make logging handler non-blocking

It takes a second or more to post a GraceDB log message. For logging purposes, this can be a significant contribution (e.g., in the case of BAYESTAR). This patch modifies the logging handler (`ligo.gracedb.logging.GraceDbLogHandler`) to write the log messages on a background thread, freeing up the main thread for more computations.

To the best of my knowledge, BAYESTAR is the only client of this module. This patch speeds up BAYESTAR for a particular sample event by about six seconds (from 42.9 down to 37.0 s) on `ldas-pcdev2.ligo.caltech.edu`.

See merge request !2

It takes a second or more to post a GraceDB log message. For
logging purposes, this can be a significant contribution (e.g.,
in the case of BAYESTAR). This patch modifies the logging handler
(`ligo.gracedb.logging.GraceDbLogHandler`) to write the log messages
on a background thread, freeing up the main thread for more
computations.

To the best of my knowledge, BAYESTAR is the only client of this
module.

Implements Python 3 compatibility for gracedb-client.