From 414438d68f9af7f50541406bd5644c2ff869cb6c Mon Sep 17 00:00:00 2001
From: "chad.hanna" <crh184@psu.edu>
Date: Sat, 17 Nov 2018 14:07:58 -0800
Subject: [PATCH] gstlal_ll_inspiral_daily_page: fix some comments and comment
 out plot background code, which isn't working

---
 gstlal-inspiral/bin/gstlal_ll_inspiral_daily_page | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/gstlal-inspiral/bin/gstlal_ll_inspiral_daily_page b/gstlal-inspiral/bin/gstlal_ll_inspiral_daily_page
index 2b99c5a35b..45ac782c03 100755
--- a/gstlal-inspiral/bin/gstlal_ll_inspiral_daily_page
+++ b/gstlal-inspiral/bin/gstlal_ll_inspiral_daily_page
@@ -160,7 +160,7 @@ if __name__ == '__main__':
 	progressbar = ProgressBar("Merge noninjection files", len(noninj_files_to_merge))
 	for f in noninj_files_to_merge:
 		subprocess.check_call(["ligolw_sqlite", "--ilwdchar-compat", "--tmp-space", os.environ["TMPDIR"], "--verbose", "--database", "%s" % noninjdb, "%s" % f])
-		# Do not cluster! the online analysis doesn't do a global clustering stage!!
+		# NOTE the online analysis doesn't do a global clustering stage!! That means that you will under count the events in the final db
 		try:
 			subprocess.check_call(["lalapps_run_sqlite", "--verbose", "--sql-file", cluster_file,  "%s" % noninjdb])
 		except subprocess.CalledProcessError as runsqlite_error:
@@ -172,7 +172,7 @@ if __name__ == '__main__':
 		progressbar = ProgressBar("Merge injection files", len(inj_files_to_merge[injection_file]))
 		for f in inj_files_to_merge[injection_file]:
 			subprocess.check_call(["ligolw_sqlite", "--ilwdchar-compat", "--tmp-space", os.environ["TMPDIR"], "--verbose", "--database", "%s" % injdb[injection_file], "%s" % f])
-			# Do not cluster! the online analysis doesn't do a global clustering stage!!
+			# NOTE the online analysis doesn't do a global clustering stage!! That means that you will under count the events in the final db
 			try:
 				subprocess.check_call(["lalapps_run_sqlite", "--verbose", "--sql-file", cluster_file,  "%s" % injdb[injection_file]])
 			except subprocess.CalledProcessError as runsqlite_error:
@@ -210,10 +210,11 @@ if __name__ == '__main__':
 	# Plot background
 	#
 
-	try:
-		subprocess.check_call(["gstlal_inspiral_plot_background", "--output-dir", plot_dir, "--user-tag", "ALL", "--database", noninjdb, "--verbose", "rankingstat_pdf.xml.gz"])
-	except subprocess.CalledProcessError as plot_error:
-		print >> sys.stderr, "plotting failed. recieved error%s...continuing anyway" % plot_error
+	# FIXME this is broken for some reason online
+#	try:
+#		subprocess.check_call(["gstlal_inspiral_plot_background", "--output-dir", plot_dir, "--user-tag", "ALL", "--database", noninjdb, "--verbose", "rankingstat_pdf.xml.gz"])
+#	except subprocess.CalledProcessError as plot_error:
+#		print >> sys.stderr, "plotting failed. recieved error%s...continuing anyway" % plot_error
 
 	#
 	# Plot summary
-- 
GitLab