Skip to content

Changes

Page history
Update Mass gap review authored by Sarah Antier's avatar Sarah Antier
Show whitespace changes
Inline Side-by-side
Mass-gap-review.md
View page @ 28a7f315
......@@ -24,20 +24,17 @@ Sushant Sharma Chaudhury, Deep Chatterjee
## Review charge
## Deliverables
1. Reviewers must ensure compatibility of all new codes related to mass-gap and existing codes in GW-celery : [approved ](https://git.ligo.org/emfollow/em-properties/em-bright/-/merge_requests/41#note_610372)
2. [Task 2 Clear and documented deliverables](https://git.ligo.org/emfollow/em-properties/em-bright/-/issues/25)
1. Reviewers must ensure compatibility of all new codes related to mass-gap and existing codes (the version of EM bright validated on Jan 2022 with EOS Marginalization + changes for compatibility of external packages) with the Python version (3.8 and 3.9 for the production code and 3.10 for the testing) to be used by GWcelery (another merge-request is made to include the EM-Bright package with HasMassgap) --> Approved with Shaon
Need to check if the pickle files produced by the package is readable by the GWCelery task that will be running in low-latency system → this has been already checked, see this example --> under discussion
2. Reviewers will set up acceptance criteria for the MassGap probabilities accuracy to be included in the 4th observing run. The reviewers will then enforce this requirement via the O3 MDCs (below 8) --> under discussion
3. Reviewers will review the software documentation after task 2, testing (under discussion) and deployment procedure
3. Reviewers will ensure the configuration control as delineated in the following RODA document is followed during the O4 run.
3.[Task 3 Performances](https://git.ligo.org/emfollow/em-properties/em-bright/-/issues/26)
4. [task 4 compatibility with GW celery post modification of the code after the review](https://git.ligo.org/emfollow/em-properties/em-bright/-/issues/27)
5. [Software documentation](https://git.ligo.org/emfollow/em-properties/em-bright/-/issues/28)
6. [RODA](https://git.ligo.org/emfollow/em-properties/em-bright/-/issues/29)
## Step-wise installation of packages:
1. Clone the repository in a desired directory.
......