| ... | ... | @@ -63,6 +63,7 @@ This outputs (p_NS, p_EMB, p_massgap) |
|
|
|
### What we checked:
|
|
|
|
- The code is running for both Coughlin and Antier on condor thanks to the instructions (Installation is very easy, thanks): https://git.ligo.org/emfollow/em-properties/em-bright/-/wikis/Mass-gap-review
|
|
|
|
- clf_kwargs = {'n_estimators':50, 'criterion':'gini', 'max_depth': 20, 'max_features': None, 'min_samples_leaf': 5, 'min_samples_split': 20} is consistent with "https://git.ligo.org/emfollow/em-properties/mass_gap/-/blob/main/mass_gap_grid_search.ipynb" parameters based on the hyper-parameter tuning grid search
|
|
|
|
- We looked at the jupyter notebooks and proposed MR (https://git.ligo.org/emfollow/em-properties/em-bright/-/merge_requests/41/diffs#16f7de7cdc8de9da5a39214ab57e1c93fb081629)
|
|
|
|
|
|
|
|
### Possible improvements:
|
|
|
|
- conf.ini could benefit from more comments (some examples are below):
|
| ... | ... | |
