Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
gwcelery
gwcelery
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 52
    • Issues 52
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 12
    • Merge Requests 12
  • Requirements
    • Requirements
    • List
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • emfollow
  • gwcelerygwcelery
  • Issues
  • #154

Closed
Open
Opened May 10, 2019 by Leo Pound Singer@leo-singerOwner

Turn off eager mode in unit tests

Celery has an option called eager mode that switches all task execution from asynchronous to synchronous. We have eager mode turned on during the unit tests. It makes writing tests easier, but it makes it so that our tests cannot detect concurrency issues such as canvas deadlocks or core Celery bugs in handling complex pipelines.

Turning off eager mode in the unit tests would make it more likely that our tests would catch failure modes like what happened with S190510g.

CC @stuart.anderson, @roberto.depietri, @deep.chatterjee, @patrick-brady.

Edited May 10, 2019 by Leo Pound Singer
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: emfollow/gwcelery#154