Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
gwcelery
gwcelery
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 52
    • Issues 52
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 12
    • Merge Requests 12
  • Requirements
    • Requirements
    • List
  • Operations
    • Operations
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • emfollow
  • gwcelerygwcelery
  • Issues
  • #342

Closed
Open
Opened Mar 24, 2020 by Leo Pound Singer@leo-singerOwner0 of 1 task completed0/1 task

Follow-up from "Fix bug that broke BAYESTAR localizations for PyCBC events"

The following discussion from !775 (merged) should be addressed:

  • @brandon.piotrzkowski started a discussion: (+1 comment)

    Just to make sure, is there any way to write this with the if statement inside the canvas? Then this would be a one line change.

As I replied:

In general, yes, there is: we can use Python's ternary if expression, a if b else c, inside canvases. However, it's not straightforward to do that here given the existing structure of the function, because PyCBC needs to be triggered by new LVAlert messages and all the other pipelines need to be triggered by log LVAlert messages.

It's a good idea to refactor this to eliminate the code duplication. Is it OK with you if I open an issue to remind myself to do that at a later date?

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: emfollow/gwcelery#342