Commit 235d0847 authored by Sean Leavey's avatar Sean Leavey
Browse files

Add setuptools_scm as dev dependency to fix makefile issue

parent 555e82e1
......@@ -13,6 +13,14 @@ else
override NUM_THREADS = $(CPU_COUNT)
endif
# Ideally we should use a packaging tool command like pip here instead of just `python
# setup.py build_ext` because calling `setup.py` directly does not respect PEP 517 and
# does not regenerate version.py when it's deleted (e.g. with a `make realclean`) and
# does not build in an isolated environment. Unfortunately the pip command is far
# slower, and rebuilds extensions even if nothing has changed, so for now we keep the
# `setup.py` command and instead just make sure that the build dependencies specified in
# `pyproject.toml` are present in the local environment, which seems to allow version.py
# to get rebuilt.
BUILD_CMD = python setup.py build_ext -j $(NUM_THREADS) --inplace
default:
......
......@@ -36,7 +36,7 @@ install_requires =
# for more information.
# Pin these to specific packages so updates don't break Finesse in the wild.
# Periodically update these to newer versions where possible.
numpy==1.20.3 # Should match that in pyproject.toml build-system requirements.
numpy==1.20.3 # Must match numpy in pyproject.toml build-system requirements.
scipy==1.6.3
matplotlib==3.4.2
networkx==2.5.1
......@@ -84,13 +84,20 @@ docs =
numpydoc
reslate
dev =
cython # Only required for `make`, which builds without isolation.
black
pre-commit
pylint
flake8
flake8-bugbear
doc8
# These dependencies are not strictly necesssary to build Finesse wheels, since they
# occur in an isolated environment and are listed in pyproject.toml as build
# dependencies, but they *are* needed for the `make` command that rebuilds
# extensions in the local environment to work.
# These requirements (and versions, if present) must match those in pyproject.toml
# build-system requirements.
cython
setuptools_scm[toml]
graphviz =
pygraphviz
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment