Commit 67f74a39 authored by Sean Leavey's avatar Sean Leavey
Browse files

Add Cython as a setup dependency

parent d24a2a1a
......@@ -115,11 +115,14 @@ removing the package.
3. Remove the line containing the package name from the relevant requirements file.
4. Delete the line containing the package name from
a. the ``REQUIRES`` list in ``setup.py`` if it is a core package required to run
|Finesse| OR
b. the ``EXTRAS`` dict in ``setup.py`` if it is any other type of package.
4. Delete the line containing the package name from one of the following data structures
in ``setup.py``:
a. ``REQUIREMENTS`` if it is a core package required to run |Finesse|,
b. ``SETUP_REQUIREMENTS`` if it is a requirement only to build or install |Finesse|,
OR
c. ``EXTRA_REQUIREMENTS`` if it is an optional extra that should not be installed by
default.
5. Verify that the test suites pass with the package removed from your local machine -
see :ref:`testing` - before attempting to merge the changes.
......@@ -224,9 +224,11 @@ def ext_modules():
)
### NOTE See https://finesse.readthedocs.io/en/latest/developer/codeguide/requirements.html
REQUIRES = [
# Dependencies for runtime, setup/build and optional extras.
# NOTE: these should not pin versions unless there are incompatibilities with the latest
# releases, in which case leave a comment as to why (see
# https://finesse.readthedocs.io/en/latest/developer/codeguide/requirements.html).
REQUIREMENTS = [
"numpy",
"scipy",
"matplotlib",
......@@ -238,11 +240,9 @@ REQUIRES = [
"click-default-group",
"tabulate",
]
EXTRAS = {
SETUP_REQUIREMENTS = ["setuptools_scm", "numpy", "Cython"]
EXTRA_REQUIREMENTS = {
"dev": [
# Building.
"cython",
# Documentation.
"sphinx",
"sphinx_rtd_theme",
......@@ -358,9 +358,9 @@ setup(
},
# requirements
python_requires=">=3.8",
install_requires=REQUIRES,
setup_requires=["setuptools_scm", "numpy"],
extras_require=EXTRAS,
install_requires=REQUIREMENTS,
setup_requires=SETUP_REQUIREMENTS,
extras_require=EXTRA_REQUIREMENTS,
# other
license="GPL",
classifiers=CLASSIFIERS,
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment