Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
  • Sign in
F
finesse3
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 9
    • Issues 9
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • Container Registry
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
  • finesse
  • finesse3
  • Merge Requests
  • !1

Closed
Opened Jul 30, 2019 by Lee McCuller@lee-mcculler
  • Report abuse
Report abuse

WIP: Scatter digraph

This merge includes a basic matrix inverter which uses the interface necessary for network reduction of the scatter graph (the full algorithm hasn't been ported yet).

In addition. components/mirror.py and simulation.py have been annotated with ideas to improve/modify the matrix fill interface to accomodate the network graph interface, as well as make it a bit more maintainable through a visitor pattern + manipulation/query interface.

It also includes setup to use py.test for testing. Highly recommended over notebooks, particularly if fixtures are used to setup output paths for plots. With pytest-watch also installed, the test code runs as you modify code. Highly efficient.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch "https://git.ligo.org/lee-mcculler/finesse3.git" "scatter_digraph"
git checkout -b "lee-mcculler/finesse3-scatter_digraph" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "lee-mcculler/finesse3-scatter_digraph"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 2
  • Commits 2
  • Changes 13
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: finesse/finesse3!1