1. 14 Feb, 2018 5 commits
  2. 13 Feb, 2018 2 commits
  3. 12 Feb, 2018 4 commits
  4. 11 Feb, 2018 4 commits
  5. 10 Feb, 2018 7 commits
  6. 08 Mar, 2017 1 commit
  7. 08 Feb, 2017 2 commits
  8. 18 Jan, 2017 2 commits
  9. 17 Jan, 2017 1 commit
  10. 11 Jan, 2017 2 commits
  11. 11 Dec, 2016 4 commits
  12. 10 Dec, 2016 5 commits
    • Edward Fauchon-Jones's avatar
    • Edward Fauchon-Jones's avatar
    • Edward Fauchon-Jones's avatar
      Remove anti-pattern of classmethods · 4c054494
      Edward Fauchon-Jones authored
      The `Spec` class family were originally set up to work using class
      methods. This was natural because each `Spec` derivative only
      represented a single field.
      With the addition of the `Amplm` and `Phaselm` specs, this was no longer
      true, with each of these specs required to represent a collection of
      fields. While initially attempted to use instances for these `Specs` and
      classes+classmethods for the remaining specs, to much off the logic
      required casing on the `Spec` being an instance of class, it was decided
      to only use classes and classmethods.
      In the end this resulting in a massive anti-pattern, defining a class
      factory in place of instance initialisers in the `Amplm` and `Phaselm`
      classes, and a general bad logic. It made sense to use classmethods
      before, but in no longer did.
      This commit refactors most classmethods as instance methods (with a
      couple left as classmethods because theydo not reference the parent
      object, and could infact be staic methods). While a couple of
      expressions required additional `()` to instance `Specs`, overall the
      logic has been greatly simplified and actually demonstrated that the
      classmethod paradigm previously used had significantly little benifit.
    • Edward Fauchon-Jones's avatar
      Add error for out of range strain mode order · 63de1fb9
      Edward Fauchon-Jones authored
      Add error to handle case when absolute value of the mode's order
      exceeds its degree.
    • Edward Fauchon-Jones's avatar
      Add strain modes (specs, creation, lvcnrcheck) · 41e31138
      Edward Fauchon-Jones authored
      - Specs have been added that represent phase and amplitude modes.
      - 5 degrees with everyone order of phase and amp modes fields are now
        created by `createValidSim`
      - `lvcnrcheck` looks for and validates phase and amp modes.
  13. 09 Dec, 2016 1 commit