python-ligo-lw issueshttps://git.ligo.org/kipp/python-ligo-lw/-/issues2024-03-28T09:33:20Zhttps://git.ligo.org/kipp/python-ligo-lw/-/issues/29Build fails with Python 3.12 and clang 16 on macOS2024-03-28T09:33:20ZDuncan Macleodduncan.macleod@ligo.orgBuild fails with Python 3.12 and clang 16 on macOSThe build of `python-ligo-lw` fails when using Python 3.12.2 and clang 16.0.1:
```console
$ sw_vers
ProductName: macOS
ProductVersion: 11.7.10
BuildVersion: 20G1427
$ git describe --tags
1.8.0-83-gcfaddad282
$ python3 --version
Pyt...The build of `python-ligo-lw` fails when using Python 3.12.2 and clang 16.0.1:
```console
$ sw_vers
ProductName: macOS
ProductVersion: 11.7.10
BuildVersion: 20G1427
$ git describe --tags
1.8.0-83-gcfaddad282
$ python3 --version
Python 3.12.2
$ clang --version
clang version 16.0.6
Target: x86_64-apple-darwin20.6.0
Thread model: posix
InstalledDir: /Users/duncanmacleod/opt/mambaforge/envs/py312/bin
$ python3 setup.py build
/Users/duncanmacleod/opt/mambaforge/envs/py312/lib/python3.12/site-packages/setuptools/dist.py:700: SetuptoolsDeprecationWarning: The namespace_packages parameter is deprecated.
!!
********************************************************************************
Please replace its usage with implicit namespaces (PEP 420).
See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages for details.
********************************************************************************
!!
ep.load()(self, ep.name, value)
running build
running build_py
creating build
creating build/lib.macosx-10.9-x86_64-cpython-312
creating build/lib.macosx-10.9-x86_64-cpython-312/ligo
creating build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw
copying ligo/lw/ligolw.py -> build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw
copying ligo/lw/lsctables.py -> build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw
copying ligo/lw/__init__.py -> build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw
copying ligo/lw/param.py -> build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw
copying ligo/lw/types.py -> build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw
copying ligo/lw/dbtables.py -> build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw
copying ligo/lw/table.py -> build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw
copying ligo/lw/array.py -> build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw
creating build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw/utils
copying ligo/lw/utils/ligolw_add.py -> build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw/utils
copying ligo/lw/utils/search_summary.py -> build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw/utils
copying ligo/lw/utils/ilwd.py -> build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw/utils
copying ligo/lw/utils/segments.py -> build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw/utils
copying ligo/lw/utils/__init__.py -> build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw/utils
copying ligo/lw/utils/ligolw_sqlite.py -> build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw/utils
copying ligo/lw/utils/coincs.py -> build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw/utils
copying ligo/lw/utils/process.py -> build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw/utils
copying ligo/lw/utils/time_slide.py -> build/lib.macosx-10.9-x86_64-cpython-312/ligo/lw/utils
running build_ext
building 'ligo.lw.tokenizer' extension
creating build/temp.macosx-10.9-x86_64-cpython-312
creating build/temp.macosx-10.9-x86_64-cpython-312/ligo
creating build/temp.macosx-10.9-x86_64-cpython-312/ligo/lw
x86_64-apple-darwin13.4.0-clang -fno-strict-overflow -DNDEBUG -O2 -Wall -fPIC -O2 -isystem /Users/duncanmacleod/opt/mambaforge/envs/py312/include -fPIC -O2 -isystem /Users/duncanmacleod/opt/mambaforge/envs/py312/include -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -isystem /Users/duncanmacleod/opt/mambaforge/envs/py312/include -D_FORTIFY_SOURCE=2 -isystem /Users/duncanmacleod/opt/mambaforge/envs/py312/include -Iligo/lw -I/Users/duncanmacleod/opt/mambaforge/envs/py312/include/python3.12 -c ligo/lw/tokenizer.RowBuilder.c -o build/temp.macosx-10.9-x86_64-cpython-312/ligo/lw/tokenizer.RowBuilder.o
ligo/lw/tokenizer.RowBuilder.c:231:2: warning: suggest braces around initialization of subobject [-Wmissing-braces]
PyObject_HEAD_INIT(NULL)
^~~~~~~~~~~~~~~~~~~~~~~~
/Users/duncanmacleod/opt/mambaforge/envs/py312/include/python3.12/object.h:141:11: note: expanded from macro 'PyObject_HEAD_INIT'
{ 1 }, \
^
ligo/lw/tokenizer.RowBuilder.c:231:2: error: incompatible pointer to integer conversion initializing 'Py_ssize_t' (aka 'long') with an expression of type 'void *' [-Wint-conversion]
PyObject_HEAD_INIT(NULL)
^~~~~~~~~~~~~~~~~~~~~~~~
/Users/duncanmacleod/opt/mambaforge/envs/py312/include/python3.12/object.h:142:9: note: expanded from macro 'PyObject_HEAD_INIT'
(type) \
^~~~~~
1 warning and 1 error generated.
error: command '/Users/duncanmacleod/opt/mambaforge/envs/py312/bin/x86_64-apple-darwin13.4.0-clang' failed with exit code 1
```
I think the `PyObject_HEAD_INIT(NULL)` needs to be modified to be `PyVarObject_HEAD_INIT(NULL, 0)`.https://git.ligo.org/kipp/python-ligo-lw/-/issues/282.0.0 release plans?2024-02-07T08:23:05ZSteffen Grunewald2.0.0 release plans?I just discovered the (11 months old) update of `debian/changelog` bumping the version to 2.0.0. Are there any plans to release this version, as a tarball and/or via PyPI?I just discovered the (11 months old) update of `debian/changelog` bumping the version to 2.0.0. Are there any plans to release this version, as a tarball and/or via PyPI?https://git.ligo.org/kipp/python-ligo-lw/-/issues/27update python interpreter2023-03-17T15:28:14ZLeo Tsukadaupdate python interpreterI tried running `ligolw_run_sqlite` and [this line](https://git.ligo.org/kipp.cannon/python-ligo-lw/-/blob/master/bin/ligolw_run_sqlite#L1) needs to be updated with `python3` as `python` interpreter is no longer available in cit. All oth...I tried running `ligolw_run_sqlite` and [this line](https://git.ligo.org/kipp.cannon/python-ligo-lw/-/blob/master/bin/ligolw_run_sqlite#L1) needs to be updated with `python3` as `python` interpreter is no longer available in cit. All other programs in `bin` needs to have this change.https://git.ligo.org/kipp/python-ligo-lw/-/issues/26API change / documentation request for changed use of process_params2023-03-03T17:21:01ZRichard O'ShaughnessyAPI change / documentation request for changed use of process_paramsOne of the RIFT [CI tests](https://git.ligo.org/rapidpe-rift/rift/-/blob/master/.travis/test-run.sh) is failing with the latest version of python-ligo-lw due to what seems to be an API/supported XML change.
```
./command-single.sh
<sni...One of the RIFT [CI tests](https://git.ligo.org/rapidpe-rift/rift/-/blob/master/.travis/test-run.sh) is failing with the latest version of python-ligo-lw due to what seems to be an API/supported XML change.
```
./command-single.sh
<snip standard messages>
====Loading injection XML: mdc.xml.gz 0 =======
Traceback (most recent call last):
File "/home/serguei.ossokine/.conda/envs/gwsignal_for_RIFT/bin/integrate_likelihood_extrinsic_batchmode", line 418, in <module>
P_list = lalsimutils.xml_to_ChooseWaveformParams_array(str(opts.sim_xml))
File "/home/serguei.ossokine/.conda/envs/gwsignal_for_RIFT/lib/python3.9/site-packages/RIFT/lalsimutils.py", line 1795, in xml_to_ChooseWaveformParams_array
[Ps[i-minrow].copy_lsctables_sim_inspiral(sim_insp[i]) for i in rng]
File "/home/serguei.ossokine/.conda/envs/gwsignal_for_RIFT/lib/python3.9/site-packages/RIFT/lalsimutils.py", line 1795, in <listcomp>
[Ps[i-minrow].copy_lsctables_sim_inspiral(sim_insp[i]) for i in rng]
File "/home/serguei.ossokine/.conda/envs/gwsignal_for_RIFT/lib/python3.9/site-packages/RIFT/lalsimutils.py", line 1724, in copy_lsctables_sim_inspiral
setattr(swigrow, simattr,0)
AttributeError: 'lalmetaio.SimInspiralTable' object has no attribute 'process:process_id'
```https://git.ligo.org/kipp/python-ligo-lw/-/issues/25Missing lalsuite dependency.2022-11-29T09:06:00ZPierre ChanialMissing lalsuite dependency.The python-ligo-lw dependency on lalsuite is not declared. And as a consequence, this package cannot be installed from PyPI with all its dependencies.The python-ligo-lw dependency on lalsuite is not declared. And as a consequence, this package cannot be installed from PyPI with all its dependencies.https://git.ligo.org/kipp/python-ligo-lw/-/issues/21distutils is deprecated as of Python 3.102023-03-17T16:09:40ZDuncan Macleodduncan.macleod@ligo.orgdistutils is deprecated as of Python 3.10The `distutils` module is deprecated as of Python 3.10 and will be removed in Python 3.12. This project should proabably switch to `setuptools` as a drop-in replacement. For full details, see <https://docs.python.org/3/whatsnew/3.10.html...The `distutils` module is deprecated as of Python 3.10 and will be removed in Python 3.12. This project should proabably switch to `setuptools` as a drop-in replacement. For full details, see <https://docs.python.org/3/whatsnew/3.10.html#distutils-deprecated>.