Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • P python-ligo-lw
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
    • Requirements
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Kipp Cannon
  • python-ligo-lw
  • Merge requests
  • !22

WIP: enable zst compression using new compress= kwarg

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Leo Pound Singer requested to merge leo-singer/python-ligo-lw:zstandard-compression into master Aug 03, 2020
  • Overview 9
  • Commits 6
  • Pipelines 1
  • Changes 5

FIXME: The one-liner expression that many scripts have to pass to write_filename will become unwieldy as the number of available compression methods grows from 1 to 2 or even more. Instead of this:

write_filename(
	filename,
	compress = compress = 'gz' if (options.output or "stdout").endswith(".gz") else False
)

this patch proposes a new compress_for_filename helper function:

write_filename(
	filename,
	compress = compress_for_filename(filename)
)

However, even this breaks the DRY principle.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: zstandard-compression