Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
P
python-ligo-lw
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 4
    • Merge Requests 4
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Kipp Cannon
  • python-ligo-lw
  • Merge Requests
  • !22

Open
Opened Aug 03, 2020 by Leo Pound Singer@leo-singerContributor
  • Report abuse
Report abuse

WIP: enable zst compression using new compress= kwarg

  • Overview 8
  • Commits 6
  • Pipelines 1
  • Changes 5

FIXME: The one-liner expression that many scripts have to pass to write_filename will become unwieldy as the number of available compression methods grows from 1 to 2 or even more. Instead of this:

write_filename(
	filename,
	compress = compress = 'gz' if (options.output or "stdout").endswith(".gz") else False
)

this patch proposes a new compress_for_filename helper function:

write_filename(
	filename,
	compress = compress_for_filename(filename)
)

However, even this breaks the DRY principle.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: kipp.cannon/python-ligo-lw!22
Source branch: zstandard-compression