From 1a4691327daf474bea45a0b9c3f19f93a24ad938 Mon Sep 17 00:00:00 2001
From: Sylvia Biscoveanu <sylvia.biscoveanu@ligo.org>
Date: Wed, 18 Jan 2023 13:36:20 +0000
Subject: [PATCH] BUGFIX: Fix SNR calculation with relative binning
---
bilby/gw/conversion.py | 4 ++--
examples/gw_examples/injection_examples/relative_binning.py | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/bilby/gw/conversion.py b/bilby/gw/conversion.py
index 6d23413f6..7eb65b2b5 100644
--- a/bilby/gw/conversion.py
+++ b/bilby/gw/conversion.py
@@ -1407,7 +1407,7 @@ def compute_snrs(sample, likelihood, npool=1):
if likelihood is not None:
if isinstance(sample, dict):
likelihood.parameters.update(sample)
- signal_polarizations = likelihood.waveform_generator.frequency_domain_strain(sample)
+ signal_polarizations = likelihood.waveform_generator.frequency_domain_strain(likelihood.parameters.copy())
for ifo in likelihood.interferometers:
per_detector_snr = likelihood.calculate_snrs(signal_polarizations, ifo)
sample['{}_matched_filter_snr'.format(ifo.name)] =\
@@ -1461,7 +1461,7 @@ def _compute_snrs(args):
sample = dict(sample).copy()
likelihood.parameters.update(sample)
signal_polarizations = likelihood.waveform_generator.frequency_domain_strain(
- sample
+ likelihood.parameters.copy()
)
snrs = list()
for ifo in likelihood.interferometers:
diff --git a/examples/gw_examples/injection_examples/relative_binning.py b/examples/gw_examples/injection_examples/relative_binning.py
index bc224ca62..172028bc3 100644
--- a/examples/gw_examples/injection_examples/relative_binning.py
+++ b/examples/gw_examples/injection_examples/relative_binning.py
@@ -105,7 +105,6 @@ for key in [
"phase",
]:
priors[key] = injection_parameters[key]
-priors["fiducial"] = 0
# Perform a check that the prior does not extend to a parameter space longer than the data
priors.validate_prior(duration, minimum_frequency)
--
GitLab