From 88d5d94f4f84d9b398384f8920a6e00ca8351379 Mon Sep 17 00:00:00 2001
From: Gregory Ashton <gregory.ashton@ligo.org>
Date: Tue, 12 May 2020 04:11:16 -0500
Subject: [PATCH] Fix flake8 issues from flake v3.8.0
---
bilby/core/utils.py | 1 +
bilby/gw/result.py | 2 +-
examples/core_examples/occam_factor_example.py | 4 ++--
test/result_test.py | 2 +-
4 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/bilby/core/utils.py b/bilby/core/utils.py
index b8d2523e8..f2bb692ae 100644
--- a/bilby/core/utils.py
+++ b/bilby/core/utils.py
@@ -1196,6 +1196,7 @@ def latex_plot_format(func):
def safe_save_figure(fig, filename, **kwargs):
+ check_directory_exists_and_if_not_mkdir(os.path.dirname(filename))
from matplotlib import rcParams
try:
fig.savefig(fname=filename, **kwargs)
diff --git a/bilby/gw/result.py b/bilby/gw/result.py
index 3ed3773da..1e106a50e 100644
--- a/bilby/gw/result.py
+++ b/bilby/gw/result.py
@@ -867,7 +867,7 @@ class CompactBinaryCoalescenceResult(CoreResult):
deg2perpix).astype(int)
for i, p in zip(ii, pp):
text.append(
- u'{:d}% area: {:d} deg$^2$'.format(p, i, grouping=True))
+ u'{:d}% area: {:d} deg$^2$'.format(p, i))
ax.text(1, 1, '\n'.join(text), transform=ax.transAxes, ha='right')
filename = os.path.join(self.outdir, "{}_skymap.png".format(self.label))
diff --git a/examples/core_examples/occam_factor_example.py b/examples/core_examples/occam_factor_example.py
index 7785a540f..319b988c0 100644
--- a/examples/core_examples/occam_factor_example.py
+++ b/examples/core_examples/occam_factor_example.py
@@ -109,8 +109,8 @@ log_evidences = []
log_evidences_err = []
log_occam_factors = []
ns = range(1, 11)
-for l in ns:
- e, e_err, o = fit(l)
+for ll in ns:
+ e, e_err, o = fit(ll)
log_evidences.append(e)
log_evidences_err.append(e_err)
log_occam_factors.append(o)
diff --git a/test/result_test.py b/test/result_test.py
index 7ef0c4047..422b42778 100644
--- a/test/result_test.py
+++ b/test/result_test.py
@@ -399,7 +399,7 @@ class TestResult(unittest.TestCase):
self.assertEqual(len(self.result.posterior), len(self.result.prior_values))
def test_plot_multiple(self):
- filename = "multiple.png".format(self.result.outdir)
+ filename = "{}/multiple.png".format(self.result.outdir)
bilby.core.result.plot_multiple([self.result, self.result], filename=filename)
self.assertTrue(os.path.isfile(filename))
os.remove(filename)
--
GitLab