From 94822143a7bfac97249ab389bd41671f403ebc13 Mon Sep 17 00:00:00 2001
From: Charlie Hoy <charlie.hoy@ligo.org>
Date: Mon, 15 Jul 2019 23:12:00 -0500
Subject: [PATCH] fixing issue #391

---
 bilby/gw/conversion.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/bilby/gw/conversion.py b/bilby/gw/conversion.py
index 29b4dafd1..7f84917c8 100644
--- a/bilby/gw/conversion.py
+++ b/bilby/gw/conversion.py
@@ -864,9 +864,12 @@ def generate_component_spins(sample):
                 output_sample['reference_frequency'], output_sample['phase'])
 
         output_sample['phi_1'] =\
-            np.arctan(output_sample['spin_1y'] / output_sample['spin_1x'])
+            np.fmod(2 * np.pi + np.arctan2(
+                output_sample['spin_1y'], output_sample['spin_1x']), 2 * np.pi)
         output_sample['phi_2'] =\
-            np.arctan(output_sample['spin_2y'] / output_sample['spin_2x'])
+            np.fmod(2 * np.pi + np.arctan2(
+                output_sample['spin_2y'], output_sample['spin_2x']), 2 * np.pi)
+
     elif 'chi_1' in output_sample and 'chi_2' in output_sample:
         output_sample['spin_1x'] = 0
         output_sample['spin_1y'] = 0
-- 
GitLab