bilby issueshttps://git.ligo.org/lscsoft/bilby/-/issues2020-01-15T04:09:08Zhttps://git.ligo.org/lscsoft/bilby/-/issues/444Restructure prior module2020-01-15T04:09:08ZMoritz HuebnerRestructure prior moduleThe `prior.py` module is pushing towards 4000 lines of code since we had some recent additions (Joint priors, conditional priors). I suggest splitting this up into separate modules while maintaining backwards compatibility. I am happy t...The `prior.py` module is pushing towards 4000 lines of code since we had some recent additions (Joint priors, conditional priors). I suggest splitting this up into separate modules while maintaining backwards compatibility. I am happy to have a look into this soon.1.0.0https://git.ligo.org/lscsoft/bilby/-/issues/496Bug in the evidence from merged runs2020-06-30T23:02:20ZGregory Ashtongregory.ashton@ligo.orgBug in the evidence from merged runsThe evidence from merged runs is being over estimated due to [this line](https://git.ligo.org/lscsoft/bilby/-/blob/master/bilby/core/result.py#L1653).
To verify this, here is some example code:
```python
In [19]: from scipy.special imp...The evidence from merged runs is being over estimated due to [this line](https://git.ligo.org/lscsoft/bilby/-/blob/master/bilby/core/result.py#L1653).
To verify this, here is some example code:
```python
In [19]: from scipy.special import logsumexp
In [20]: a = np.array([11, 12, 13]) # Create fake Z's
In [21]: np.sqrt(np.mean(a**2)) # Actual RMS value calculated directly
Out[21]: 12.027745701779143
In [22]: lna = np.log(a) # Take the natural log
In [23]: np.exp(0.5 * logsumexp(2 * lna, b=1. / len(a))) # This is how the RMS should be calculated
Out[23]: 12.027745701779143
In [24]: np.exp(logsumexp(2 * lna, b=1. / len(a))) # This is how we do it currently
Out[24]: 144.66666666666666
```1.0.0Gregory Ashtongregory.ashton@ligo.orgGregory Ashtongregory.ashton@ligo.orghttps://git.ligo.org/lscsoft/bilby/-/issues/308Support for time domain waveforms2020-07-14T15:28:29ZMichael PuerrerSupport for time domain waveformsBilby uses lalsimulation's [`XLALSimInspiralChooseFDWaveform()`](https://git.ligo.org/lscsoft/bilby/blob/master/bilby/gw/utils.py#L765) to obtain Fourier domain waveforms.
To add support for time domain waveforms I would recommend to ca...Bilby uses lalsimulation's [`XLALSimInspiralChooseFDWaveform()`](https://git.ligo.org/lscsoft/bilby/blob/master/bilby/gw/utils.py#L765) to obtain Fourier domain waveforms.
To add support for time domain waveforms I would recommend to call lalsimulation's [`XLALSimInspiralFD()`](https://git.ligo.org/lscsoft/lalsuite/blob/master/lalsimulation/src/LALSimInspiral.c#L2119) to obtain Fourier domain waveforms from time domain waveforms implemented in lalsimulation. This has the advantage that lalsimulation is handling the conditioning and FFT.
Carefully read the documentation about the input parameters of this function! The redshift can be passed in the LALDict.1.0.0Colm Talbotcolm.talbot@ligo.orgColm Talbotcolm.talbot@ligo.org