Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
bilby
bilby
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 25
    • Issues 25
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 12
    • Merge Requests 12
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • lscsoft
  • bilbybilby
  • Issues
  • #536

Closed
Open
Opened Oct 13, 2020 by Moritz Huebner@moritz.huebnerMaintainer1 of 1 task completed1/1 task

plot_waveform_posterior uses non representative samples

The following discussion from !817 (merged) should be addressed:

  • @avi.vajpeyi started a discussion: (+3 comments)

    While working on this, I noticed that if n_samples is passed to plot_waveform_posterior then n samples from the top of the posterior data frame are used (the samples with the lowest LogL).

    Would it be better to use the n samples from the bottom of the data frame (the samples with the highest LogL)?

    Should I make an issue about this, or am I understanding something wrong?

I think it should take random samples. In any case, we should aim to fix this soon.

Edited Nov 16, 2020 by Colm Talbot
Assignee
Assign to
Future
Milestone
Future
Assign milestone
Time tracking
None
Due date
None
Reference: lscsoft/bilby#536