Bilby v1.1.1 cannot parse priors with single float values?
Users of pBilby
(e.g. @isobel.romero-shaw, @francisco.hernandez, @serguei.ossokine) noted issues with bilby
parsing the prior when marginalization is turned on (details in parallel_bilby#46 (closed)).
EG:
10:57 bilby INFO : luminosity_distance: 3382.9535676090873
10:57 bilby INFO : dec: Cosine(minimum=-1.5707963267948966, maximum=1.5707963267948966, name='dec', latex_label='$\\mathrm{DEC}$', unit=None, boundary=None)
10:57 bilby INFO : ra: Uniform(minimum=0, maximum=6.283185307179586, name='ra', latex_label='$\\mathrm{RA}$', unit=None, boundary='periodic')
10:57 bilby INFO : theta_jn: Sine(minimum=0, maximum=3.141592653589793, name='theta_jn', latex_label='$\\theta_{JN}$', unit=None, boundary=None)
10:57 bilby INFO : psi: Uniform(minimum=0, maximum=3.141592653589793, name='psi', latex_label='$\\psi$', unit=None, boundary='periodic')
10:57 bilby INFO : phase: 0.0
10:57 bilby INFO : geocent_time: 1126259460.3909912
...
File "/fred/oz117/avajpeyi/.conda/envs/parallel_bilby/lib/python3.8/site-packages/bilby/core/prior/dict.py", line 706, in <listcomp>
self._rescale_indexes = [keys.index(element) for element in self.sorted_keys_without_fixed_parameters]
ValueError: 'luminosity_distance' is not in list
As suggested by @colm.talbot, pBilby
will be adjusted to ensure that priors.convert_floats_to_delta_functions
is called before running the sampler.
However, should this line in bilby
also be adjusted to look for numeric types? This might be useful for other bilby
users who do not know of this change in the PriorDict
.