bilby issueshttps://git.ligo.org/lscsoft/bilby/-/issues2024-02-22T21:26:52Zhttps://git.ligo.org/lscsoft/bilby/-/issues/226Create github/gitlab mirror2024-02-22T21:26:52ZGregory Ashtongregory.ashton@ligo.orgCreate github/gitlab mirror@vivien mentioned that Tom Downes has expertise on this.@vivien mentioned that Tom Downes has expertise on this.0.4.0Gregory Ashtongregory.ashton@ligo.orgGregory Ashtongregory.ashton@ligo.orghttps://git.ligo.org/lscsoft/bilby/-/issues/484sys.exit in jupyter2022-09-29T09:53:31ZColm Talbotcolm.talbot@ligo.orgsys.exit in jupyterI'm running into issues stopping jobs in Jupiter. When I interrupt `dynesty` it triggers a call to `sys.exit` which kills the kernel.
Maybe we should avoid calling `sys.exit` and instead raise a custom error that can be caught and then ...I'm running into issues stopping jobs in Jupiter. When I interrupt `dynesty` it triggers a call to `sys.exit` which kills the kernel.
Maybe we should avoid calling `sys.exit` and instead raise a custom error that can be caught and then the exit can be called by downstream users.https://git.ligo.org/lscsoft/bilby/-/issues/501Increase sampler test coverage2020-07-13T16:00:36ZColm Talbotcolm.talbot@ligo.orgIncrease sampler test coverageCurrently, due to moving the sampler tests out of the main test script, the coverage reported is pretty low for the samplers. (There's also a less extreme case for the GW plotting which is done nightly). Most of the sampler code is actua...Currently, due to moving the sampler tests out of the main test script, the coverage reported is pretty low for the samplers. (There's also a less extreme case for the GW plotting which is done nightly). Most of the sampler code is actually tested at every push in a different job.
I'm wondering if there's a way to combine coverage reports from the `python-3.7` and `python-3.7-samplers` jobs.
An alternative would be to write a bunch of unit tests for the samplers.
`$ coverage combine` may be all we need https://coverage.readthedocs.io/en/coverage-5.2/cmd.html#combining-data-files-coverage-combineColm Talbotcolm.talbot@ligo.orgColm Talbotcolm.talbot@ligo.orghttps://git.ligo.org/lscsoft/bilby/-/issues/517Improve signal handling2020-08-19T08:04:41ZColm Talbotcolm.talbot@ligo.orgImprove signal handlingCurrently, we set the signal handler in the `__init__` methods for the samplers, e.g., https://git.ligo.org/lscsoft/bilby/-/blob/master/bilby/core/sampler/dynesty.py#L176-178.
These typically lead to calling a checkpoint function which ...Currently, we set the signal handler in the `__init__` methods for the samplers, e.g., https://git.ligo.org/lscsoft/bilby/-/blob/master/bilby/core/sampler/dynesty.py#L176-178.
These typically lead to calling a checkpoint function which only really makes sense during sampling.
This leads to some weird behaviour if the signals come after the sampler finishes or before the setup is complete. I've noticed this when jobs are interrupted during parameter reconstruction.
I suggest that instead we should set up the handler immediately before launching the sampler and change them back after the sampling is done.
We may also want to look at having a specific handler for the parameter reconstruction in the GW case.https://git.ligo.org/lscsoft/bilby/-/issues/669Update Planck15 to Planck18 ?2023-04-13T16:16:02ZWeizmann KIENDREBEOGOUpdate Planck15 to Planck18 ?
Could someone please tell me if bilby will switch to Planck18 in the near future?
https://git.ligo.org/lscsoft/bilby/-/blob/master/bilby/gw/cosmology.py#L13
thanks
Could someone please tell me if bilby will switch to Planck18 in the near future?
https://git.ligo.org/lscsoft/bilby/-/blob/master/bilby/gw/cosmology.py#L13
thankshttps://git.ligo.org/lscsoft/bilby/-/issues/716Time to remove polychord?2023-11-10T16:01:57ZColm Talbotcolm.talbot@ligo.orgTime to remove polychord?After reworking the test suite, we're still having [issues](https://git.ligo.org/lscsoft/bilby/-/jobs/3025662) with installing polychord because it has to be built from source.
I suggest that we begin the process of removing polychord a...After reworking the test suite, we're still having [issues](https://git.ligo.org/lscsoft/bilby/-/jobs/3025662) with installing polychord because it has to be built from source.
I suggest that we begin the process of removing polychord as a supported sampler. With the following process:
- remove it from the test suite ASAP.
- remove it from the package at the next major/minor release (presumably 2.3).
This would be the first time we've dropped support for a sampler, but I think it would be good to formalize that any supported sampler should be available from conda-forge.
Thoughts @gregory.ashton @michael.williams @sylvia.biscoveanu?