bilby_pipe merge requestshttps://git.ligo.org/lscsoft/bilby_pipe/-/merge_requests2024-03-27T12:05:24Zhttps://git.ligo.org/lscsoft/bilby_pipe/-/merge_requests/597Draft: Add Support for Online-Style runs using bilby_pipe_gracedb to Asimov i...2024-03-27T12:05:24ZMick Wrightmick.wright@ligo.orgDraft: Add Support for Online-Style runs using bilby_pipe_gracedb to Asimov integrationcc'ing @daniel-williams, @michael.williams, @colm.talbot
After discussion in !596, it was decided to move adding support for online-style runs using `bilby_pipe_gracedb` to `bilby_pipe` asimov integrations to it's own MR.
This MR adds...cc'ing @daniel-williams, @michael.williams, @colm.talbot
After discussion in !596, it was decided to move adding support for online-style runs using `bilby_pipe_gracedb` to `bilby_pipe` asimov integrations to it's own MR.
This MR adds an additional class to the proposed `bilby_pipe` Asimov integration to allow for automated deployment of online-style runs.
## To-Do
- [ ] Add asimov pipeline class to allow automated online-style runs
- [ ] Add testing framework for this new class
## Related MRs
- !596 must be merged first to introduce Asimov support to `bilby_pipe` codebase instead of the `asimov` codebase.https://git.ligo.org/lscsoft/bilby_pipe/-/merge_requests/596Transfer Automation from Asimov to Bilby2024-03-28T12:49:47ZMick Wrightmick.wright@ligo.orgTransfer Automation from Asimov to BilbyThis MR will transfer the code integrating `bilby` and `bilby_pipe` with `asimov` from the `asimov` codebase to the `bilby_pipe` codebase
cc'ing @daniel-williams @michael.williams
## To-Do
- [x] Move and perform testing of the `bilby`...This MR will transfer the code integrating `bilby` and `bilby_pipe` with `asimov` from the `asimov` codebase to the `bilby_pipe` codebase
cc'ing @daniel-williams @michael.williams
## To-Do
- [x] Move and perform testing of the `bilby` integration from `asimov` codebase.
- [x] Update installation procedure of `bilby_pipe` to include `entry_point` for `asimov`
- [x] Move testing procedures of the `bilby` integration from `asimov` repository to `bilby_pipe` repository
- [x] Ensure `bilby` integration CI tests pass
- [x] Add Documentation page for `asimov` plugin.https://git.ligo.org/lscsoft/bilby_pipe/-/merge_requests/593Set default getenv to LAL_DATA_PATH2024-03-15T23:07:57ZJacob GolombSet default getenv to LAL_DATA_PATHWith environment variables needed for condor jobs specified in the .sub file, I think it is reasonable to assume that a user who has set their `$LAL_DATA_PATH` wants the analysis job to use this variable. It is simple for a user to inclu...With environment variables needed for condor jobs specified in the .sub file, I think it is reasonable to assume that a user who has set their `$LAL_DATA_PATH` wants the analysis job to use this variable. It is simple for a user to include this in their config, but I think this should not be necessary as it is likely safe to assume that a user wants to use the `$LAL_DATA_PATH` they set. This MR will by default include `$LAL_DATA_PATH` in the analysis job.https://git.ligo.org/lscsoft/bilby_pipe/-/merge_requests/591Draft: Use `get_expected_outputs` for getting sampler outputs2024-03-07T14:07:27ZMichael Williamsmichael.williams@ligo.orgDraft: Use `get_expected_outputs` for getting sampler outputsFollowing the changes proposed in https://git.ligo.org/lscsoft/bilby/-/merge_requests/1336, this MR reworks `touch_checkpoint_files` to use the new class method `Sampler.get_expected_outputs`.
This should make it possible to support new...Following the changes proposed in https://git.ligo.org/lscsoft/bilby/-/merge_requests/1336, this MR reworks `touch_checkpoint_files` to use the new class method `Sampler.get_expected_outputs`.
This should make it possible to support new samplers, e.g. via a plugin, without having to update the `touch_checkpoint_files` function each time.
## To-do
- [ ] Fix abbreviations. These probably need to be handled in https://git.ligo.org/lscsoft/bilby/-/merge_requests/1336
- [ ] Test `touch_file` function to make sure it works for non-pickle files.
## Required changes
These changes need to be merged and release before this MR can be tested.
- [ ] https://git.ligo.org/lscsoft/bilby/-/merge_requests/1299
- [ ] https://git.ligo.org/lscsoft/bilby/-/merge_requests/1336
- [ ] Release of bilby with the above MRshttps://git.ligo.org/lscsoft/bilby_pipe/-/merge_requests/586Allow custom GW detectors via plugins2024-03-04T09:48:07ZCharlie HoyAllow custom GW detectors via pluginsThe purpose of this MR is to allow other packages to specify custom GW detectors, and make them discoverable/useable within `bilby_pipe`. This is dependent on https://git.ligo.org/lscsoft/bilby/-/merge_requests/1314.The purpose of this MR is to allow other packages to specify custom GW detectors, and make them discoverable/useable within `bilby_pipe`. This is dependent on https://git.ligo.org/lscsoft/bilby/-/merge_requests/1314.https://git.ligo.org/lscsoft/bilby_pipe/-/merge_requests/585Fix passing mode_array in injection-waveform-arguments2024-02-28T09:04:22ZLorenzo PompiliFix passing mode_array in injection-waveform-argumentsPossible fix for https://git.ligo.org/lscsoft/bilby_pipe/-/issues/293 by converting the `mode array` from a list of strings when passed via `injection-waveform-arguments`.Possible fix for https://git.ligo.org/lscsoft/bilby_pipe/-/issues/293 by converting the `mode array` from a list of strings when passed via `injection-waveform-arguments`.https://git.ligo.org/lscsoft/bilby_pipe/-/merge_requests/584MAINT: remove preference of lalframe.2024-01-30T14:55:49ZColm Talbotcolm.talbot@ligo.orgMAINT: remove preference of lalframe.This MR removes a hardcoded preference for lalframe. I looked back through the history and it isn't clear why we set this as the default (it appeared in [this commit](https://git.ligo.org/lscsoft/bilby_pipe/-/commit/f78539af6dc2254712d98...This MR removes a hardcoded preference for lalframe. I looked back through the history and it isn't clear why we set this as the default (it appeared in [this commit](https://git.ligo.org/lscsoft/bilby_pipe/-/commit/f78539af6dc2254712d988078614f7f9b9d14eec)).
The main issue with this method is that it cannot read some frames that are not a power of 2 in length which causes failures at the edges of observing segments.
GWpy has a [preferred order](https://gwpy.github.io/docs/stable/timeseries/io/#gwf-library-availability).
I think we should just go with this.
It's possible the original motivation was to avoid the conda dependency on framecpp, but I think we can live with that.
Also, given the recent changes to the data generation, this gwpy.get branch is no longer a preferred method.
If we really want this to be the default, we should set it in the [parser](https://git.ligo.org/lscsoft/bilby_pipe/-/blob/master/bilby_pipe/parser.py#L211).https://git.ligo.org/lscsoft/bilby_pipe/-/merge_requests/583Allow for custom input classes to be in conjunction with custom parsers2024-03-15T22:15:46ZCharlie HoyAllow for custom input classes to be in conjunction with custom parsersThe purpose of this MR is to allow for a custom input class to be in conjunction with custom parser. This fixes #290.The purpose of this MR is to allow for a custom input class to be in conjunction with custom parser. This fixes #290.https://git.ligo.org/lscsoft/bilby_pipe/-/merge_requests/532Resolve: ini file parsing error for multiple lined dictionary2023-05-25T00:32:49ZGregory Ashtongregory.ashton@ligo.orgResolve: ini file parsing error for multiple lined dictionaryImplements changes from !527 in a single MR.Implements changes from !527 in a single MR.https://git.ligo.org/lscsoft/bilby_pipe/-/merge_requests/458Draft: make PSD be generated from before and after2022-06-28T08:34:52ZColm Talbotcolm.talbot@ligo.orgDraft: make PSD be generated from before and afterMany analyses generate PSDs from data before and after the analysis segment. We've discussed this a few times and I was motivated to try it for a project I'm working on.
This is probably not an ideal implementation yet, but I wanted to ...Many analyses generate PSDs from data before and after the analysis segment. We've discussed this a few times and I was motivated to try it for a project I'm working on.
This is probably not an ideal implementation yet, but I wanted to get a feel for if there was an appetite for this.Colm Talbotcolm.talbot@ligo.orgColm Talbotcolm.talbot@ligo.org