Here we record the most up-to-date review results for bilby, intended for O3. Briefly, we test the sampler on [fiducial BBH](#fiducial-bbh), [fiducial BNS](#fiducial-bns), [PP tests](#pp-tests), and [compare with LALInference on known events](#known-events-comparison). We define a family of [prior-files](#prior-files) which span the range of expected chirp masses; these prior files form the basis of different test cases and allow easy setup for the online-PE.
### Versions
* bilby: **TODO**
* bilby-pipe: **TODO**
* sampler: dynesty [currently using this branch](https://github.com/joshspeagle/dynesty/pull/129)
### Prior files
For testing bilby, we have selected a set of priors based on the [IMRPhenomPV2 ROQ basis](https://git.ligo.org/lscsoft/ROQ_data/):
*[high_mass ](https://git.ligo.org/lscsoft/bilby_pipe/blob/master/bilby_pipe/data_files/high_mass.prior) defaults to 4s duration
To run all tests in the review, we have a [review script](https://git.ligo.org/lscsoft/bilby_pipe/blob/master/bilby_pipe/review.py). This is accessible via the command line:
**TODO** add a fiducial BNS to the review script, should it just be IMRPhenomPV2 with tides?
### PP tests
We run PP tests using 100 segments drawn from the choice of priors, with/without the ROQ. Each bullet takes you to the PP test itself, followed by the print out of the individual p-values for each parameter.
13:35 bilby INFO : chirp_mass: 0.07973494810998656
13:35 bilby INFO : dec: 0.4606878987905608
13:35 bilby INFO : geocent_time: 0.0636859419231064
13:35 bilby INFO : luminosity_distance: 0.3321788957823833
13:35 bilby INFO : mass_2: 0.09175320064298155
13:35 bilby INFO : mass_ratio: 0.017537311727554152
13:35 bilby INFO : phase: 0.2849057859042811
13:35 bilby INFO : phi_12: 0.15331929136204447
13:35 bilby INFO : phi_jl: 0.4050101300094443
13:35 bilby INFO : psi: 0.06708242507266793
13:35 bilby INFO : ra: 0.005805606437181634
13:35 bilby INFO : theta_jn: 0.6654418790695829
13:35 bilby INFO : tilt_1: 0.2000164343894656
13:35 bilby INFO : tilt_2: 0.1712076785534081
13:35 bilby INFO : Combined p-value: 0.0008182781963171137
```
**TODO** decide how many PP-tests we want and do them
**TODO** Like the 128s is failing as the setup isn't good enough. Could be remedied by either more live points/walks or running a few jobs in parallel.
### Known events comparison
All event comparisons for known events are stored in [bilby_pe_event_samples repo](https://git.ligo.org/gregory.ashton/bilby_pe_event_samples)