... | ... | @@ -30,8 +30,8 @@ GA: |
|
|
|
|
|
Question for group: what else?
|
|
|
MP:
|
|
|
* Action: Running on analytic likelihoods. 15D uni-modal and bi-modal Gaussian distribution. (https://git.ligo.org/lscsoft/lalsuite/blob/master/lalinference/src/LALInferenceAnalyticLikelihood.c for all the covariance matrices)
|
|
|
* Action: direct check of waveforms. i.e., give LALInference and Bilby fixed parameters, and ensure waveforms are identical.
|
|
|
* **Action**: Running on analytic likelihoods. 15D uni-modal and bi-modal Gaussian distribution. (https://git.ligo.org/lscsoft/lalsuite/blob/master/lalinference/src/LALInferenceAnalyticLikelihood.c for all the covariance matrices)
|
|
|
* **Action**: direct check of waveforms. i.e., give LALInference and Bilby fixed parameters, and ensure waveforms are identical.
|
|
|
* Currently no tests listed about checking calibration interpolation between the two codes
|
|
|
PL: should we test calibration against LI, or some other way?
|
|
|
|
... | ... | @@ -40,7 +40,8 @@ CH: Show recovery of prior. Put in a level of miscalibration, and see if that c |
|
|
GA: Event runs we’ve been doing all include calibration — is that sufficient?
|
|
|
|
|
|
CH: That should be sufficient, as long as spline nodes are defined at same frequency points.
|
|
|
Action - check node splines, make calibration plot comparisons
|
|
|
|
|
|
**Action** - check node splines, make calibration plot comparisons
|
|
|
|
|
|
VR: Don’t want to check dynesty itself. Just the scripts that call dynesty with default settings. Part of the review will therefore include the configuration files
|
|
|
|
... | ... | @@ -87,7 +88,7 @@ VR: gwcelery is out of scope for this review. But we would be remiss not to incl |
|
|
|
|
|
All: General agreement that this is a good idea.
|
|
|
|
|
|
*Action*: set up gracedb playground event.
|
|
|
**Action**: set up gracedb playground event.
|
|
|
|
|
|
SS: Does this include post-processing? e.g., ensuring everything is labelled correctly, etc.
|
|
|
|
... | ... | @@ -97,7 +98,7 @@ MP: Yes, this is what’s been done with LI. If the tests that are run with Bil |
|
|
|
|
|
GA: this is already being done for the fiducial runs, but not the known events — we can do this.
|
|
|
|
|
|
*Action:* we can do this.
|
|
|
**Action:** we can do this.
|
|
|
|
|
|
CH: It is in the scope of this review to review the ROQ likelihood function, just not the basis.
|
|
|
|
... | ... | |