| ... | @@ -10,9 +10,15 @@ Likelihood accuracy tests with the new format are covered as part of reviews of |
... | @@ -10,9 +10,15 @@ Likelihood accuracy tests with the new format are covered as part of reviews of |
|
|
A reduction in the number of waveform calls significantly improved performance.
|
|
A reduction in the number of waveform calls significantly improved performance.
|
|
|
[Unit testing](https://git.ligo.org/lscsoft/bilby/-/blob/master/test/gw/likelihood_test.py#L282-L828) ensured that this had no impact on likelihood evaluation.
|
|
[Unit testing](https://git.ligo.org/lscsoft/bilby/-/blob/master/test/gw/likelihood_test.py#L282-L828) ensured that this had no impact on likelihood evaluation.
|
|
|
|
|
|
|
|
## Time marginalization/reconstruction (https://git.ligo.org/lscsoft/bilby/-/merge_requests/1196)
|
|
## Time marginalization/reconstruction (https://git.ligo.org/lscsoft/bilby/-/merge_requests/1040, https://git.ligo.org/lscsoft/bilby/-/merge_requests/1196)
|
|
|
|
|
|
|
|
The ROQ likelihood can now be time marginalized and reconstructed.
|
|
The ROQ likelihood can now be time marginalized and reconstructed.
|
|
|
Marginalization is covered in the [unit tests](https://git.ligo.org/lscsoft/bilby/-/blob/master/test/gw/likelihood/marginalization_test.py).
|
|
Marginalization is covered in the [unit tests](https://git.ligo.org/lscsoft/bilby/-/blob/master/test/gw/likelihood/marginalization_test.py).
|
|
|
|
|
|
|
|
|
**Colm** to add pp-test for O4 review.
|
|
|
|
|
|
|
|
pp-test from soichiro in https://git.ligo.org/lscsoft/bilby/-/merge_requests/1040
|
|
|
|
|
|
|
|
Comparison of discrete vs interpolated time reconstruction, https://git.ligo.org/lscsoft/bilby/-/issues/667#note_636616.
|
|
|
|
|
|
|
@soichiro.morisaki is the main responsible person for ROQ development. |
|
@soichiro.morisaki is the main responsible person for ROQ development. |
|
|
|
\ No newline at end of file |
