update client tests

ligo/gracedb/rest.py

@@ -1262,7 +1262,8 @@ class GraceDb(GsiRest):
         return self.post(uri, body=request_body)
 
     def updateSuperevent(self, superevent_id, t_start=None, t_0=None,
-                         t_end=None, preferred_event=None):
+                         t_end=None, preferred_event=None, em_type=None,
+                         coinc_far=None):
         """Update a superevent's parameters.
 
         The same permission restrictions apply as for
@@ -1283,6 +1284,12 @@ class GraceDb(GsiRest):
                 superevent (``'production'``, ``'test'``, ``'mdc'``) and must
                 either already be a part of this superevent, or not be in a
                 superevent at all.
+	    em_type (:obj:`str`, optional): name of coincident EM search 
+                for "preferred" EM coincident event. Defined by analyst or
+                pipeline (e.g., RAVEN). Default is null for new superevents.
+            coinc_far (:obj:`float`, optional): new value for coincident FAR
+                with preferred EM coincident event. Defined by analyst or
+                pipeline  (e.g., RAVEN). Default is null for new superevents. 
 
         Returns:
             :class:`httplib.HTTPResponse`
@@ -1299,9 +1306,10 @@ class GraceDb(GsiRest):
             200
         """  # noqa: W605
         # Make sure that at least one parameter is provided
-        if not (t_start or t_0 or t_end or preferred_event):
-            raise ValueError('Provide at least one of t_start, t_0, t_end, or '
-                             'preferred_event')
+        if not (t_start or t_0 or t_end or preferred_event or 
+                em_type or coinc_far):
+            raise ValueError('Provide at least one of t_start, t_0, t_end, '
+                             'preferred_event, em_type, or coinc_far')
 
         request_body = {}
         if t_start is not None:
@@ -1312,6 +1320,10 @@ class GraceDb(GsiRest):
             request_body['t_end'] = t_end
         if preferred_event is not None:
             request_body['preferred_event'] = preferred_event
+        if em_type is not None:
+            request_body['em_type'] = em_type
+        if coinc_far is not None:
+            request_body['coinc_far'] = coinc_far
         template = self.templates['superevent-detail-template']
         uri = template.format(superevent_id=superevent_id)
         return self.patch(uri, body=request_body)

ligo/gracedb/test/test_events.py

@@ -329,7 +329,7 @@ def test_creation_args(
 
 
 def test_update_no_args(safe_client):
-    err_msg = 'Provide at least one of t_start, t_0, t_end, or preferred_event'
+    err_msg = 'Provide at least one of t_start, t_0, t_end, preferred_event, em_type, or coinc_far'
     with pytest.raises(ValueError, match=err_msg):
         safe_client.updateSuperevent('S181224a')
 
@@ -341,7 +341,10 @@ def test_update_no_args(safe_client):
         {'t_0': 2},
         {'t_end': 3},
         {'preferred_event': 'G0001'},
-        {'t_start': 1, 't_0': 2, 't_end': 3, 'preferred_event': 'G0001'},
+        {'em_type': 'EM_TEST'},
+        {'coinc_far': '4'},
+        {'t_start': 1, 't_0': 2, 't_end': 3, 'preferred_event': 'G0001',
+         'em_type': 'EM_TEST', 'coinc_far': '4'},
     ]
 )
 def test_update_args(safe_client, update_kwargs):

ligo/gracedb/test/test_superevents.py

@@ -119,7 +119,7 @@ def test_creation_args(
 
 
 def test_update_no_args(safe_client):
-    err_msg = 'Provide at least one of t_start, t_0, t_end, or preferred_event'
+    err_msg = 'Provide at least one of t_start, t_0, t_end, preferred_event, em_type, or coinc_far'
     with pytest.raises(ValueError, match=err_msg):
         safe_client.updateSuperevent('S181224a')
 
@@ -131,7 +131,10 @@ def test_update_no_args(safe_client):
         {'t_0': 2},
         {'t_end': 3},
         {'preferred_event': 'G0001'},
-        {'t_start': 1, 't_0': 2, 't_end': 3, 'preferred_event': 'G0001'},
+        {'em_type': 'EM_TEST'},
+        {'coinc_far': '4'},
+        {'t_start': 1, 't_0': 2, 't_end': 3, 'preferred_event': 'G0001', 
+         'em_type': 'EM_TEST', 'coinc_far': '4'},
     ]
 )
 def test_update_args(safe_client, update_kwargs):