Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
G
gracedb
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 100
    • Issues 100
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1
    • Merge Requests 1
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lscsoft
  • gracedb
  • Issues
  • #10

Closed
Open
Created Jun 25, 2018 by Tanner Prestegard@tanner.prestegardMaintainer

Some floats cast as strings in LVAlerts and response JSONs

As reported in emfollow/gwcelery!94 (merged), there are situations in which certain float variables are being sent as strings in LVAlert JSONs and even in some response JSONs from gracedb-client.

I believe this is happening because in some of the old code in the events API, the event is converted to a dictionary BEFORE it is saved in the database. Thus, some variables which are extracted from the event file (as strings) are still in memory as strings. If we did the save first, that would cast those variables to the correct type.

I will submit some test events for the active pipelines (gstlal, gstlal-spiir, pycbc, mbtaonline, cwb, lib, swift, fermi, and snews) and check the LVAlert content, as well as the response in gracedb-client.

Edited Jun 25, 2018 by Tanner Prestegard
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None