Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
G
gracedb
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 99
    • Issues 99
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1
    • Merge Requests 1
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • lscsoft
  • gracedb
  • Issues
  • #177

Closed
Open
Opened Oct 04, 2019 by Alexander Pace@alexander.paceMaintainer

Add superevent fields for RAVEN

Description of feature request

This came as a result of the face-to-face discussion at MIT during the week of October 1-4, 2019.

For implementing RAVEN's logic, it was decided to add two new data fields to superevents:

name data type default
coinc_far float null
em_type string null

Use cases

RAVEN uses these values for tracking and assigning significance for external (E) events.

Benefits

By explicitly defining the em_type it resolves the question as to which E event to choose as a "preferred" external event.

Drawbacks

There's no logic in GraceDB for choosing the preferred external event, or how to choose the coinc_far (by design). So this requires additional bookkeeping in RAVEN.

Suggested solutions

This should be a doable change, but it requires a few changes:

  • Add the new data field on the server side
  • Add a migration to alter the database for past superevents. (Should there be a script to back-populate this value?
  • Modify the updateSUperevent API call to take in the additional fields.
  • Ensure that that update LVALert gets sent out when these fields are modified.
Edited Oct 15, 2019 by Alexander Pace
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: lscsoft/gracedb#177