From 4ee78ca75fdf677df2ef74cdcd15858ff76e6780 Mon Sep 17 00:00:00 2001
From: Brian Bockelman <bbockelm@cse.unl.edu>
Date: Wed, 5 Jun 2019 15:40:29 -0500
Subject: [PATCH] Add explicit synchronization point.
If there's a large number of parent / child relationships, instead
of having a set of all-to-all arcs (which can number into the tens
of millions for many parents and children in one line), add in a
explicit no-op node. This causes the number of arcs to grow linearly
instead of quadratically.
HTCondor will do this automatically in future versions; this commit
should be reverted once the new dagman is available.
---
gstlal/python/dagfile.py | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/gstlal/python/dagfile.py b/gstlal/python/dagfile.py
index 243c68fb4a..2a0a63641a 100644
--- a/gstlal/python/dagfile.py
+++ b/gstlal/python/dagfile.py
@@ -835,6 +835,8 @@ class DAG(object):
# initialize proegress report wrapper
progress = progress_wrapper(f, progress)
+ counter = 0
+
# if needed, create a dummy object to allow .write() method
# calls
if f is None and rescue is not None:
@@ -898,7 +900,13 @@ class DAG(object):
parents_of.setdefault(frozenset(child.name for child in node.children) & names, set()).add(node.name)
for children, parents in parents_of.items():
if children:
- f.write("PARENT %s CHILD %s\n" % (" ".join(sorted(parents)), " ".join(sorted(children))))
+ if len(parents) * len(children) > 25:
+ counter += 1
+ f.write("JOB NOOP_NODE%s noop.submit NOOP\n" % str(counter))
+ f.write("PARENT %s CHILD NOOP_NODE%s\n" % (" ".join(sorted(parents)), str(counter)))
+ f.write("PARENT NOOP_NODE%s CHILD %s\n" % (str(counter), " ".join(sorted(children))))
+ else:
+ f.write("PARENT %s CHILD %s\n" % (" ".join(sorted(parents)), " ".join(sorted(children))))
progress += 1
# progress
--
GitLab