From 9b40cb817e2e09e10c5692b7905458bb9610566b Mon Sep 17 00:00:00 2001
From: ChiWai Chan <chiwai.chan@ligo.org>
Date: Wed, 4 Sep 2019 19:47:47 -0700
Subject: [PATCH] gstlal_inspiral_calc_snr: having --start / --end 650s
larger/less than --gps-start-time / --gps-end-time is probably an overkill.
Reducing it to 50s.
---
gstlal-inspiral/bin/gstlal_inspiral_calc_snr | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gstlal-inspiral/bin/gstlal_inspiral_calc_snr b/gstlal-inspiral/bin/gstlal_inspiral_calc_snr
index 3ac95adecc..56b10bc64c 100755
--- a/gstlal-inspiral/bin/gstlal_inspiral_calc_snr
+++ b/gstlal-inspiral/bin/gstlal_inspiral_calc_snr
@@ -268,9 +268,9 @@ def parse_command_line():
elif options.start >= options.end:
raise ValueError("--start must less than --end.")
# Extra handle for SNRs output because SNRs are not stable initially and have padding at the end
- # FIXME: the 650s is hardcoded (~BNS waveforms duration) and only used as a lower bound to avoid having a frame file that is too short
- if options.start - gw_data_source_info.seg[0] <= 650 or gw_data_source_info.seg[1] - options.end <= 650:
- raise ValueError("Check your inputted --start / --end or your frame file. You should have a long enough data such that, the --start/--end is larger/less than the start/end of your data at least 650s. ")
+ # FIXME: the 50s is hardcoded and only use to avoid snr being unstable due to edge effect when doing convoluion
+ if options.start - gw_data_source_info.seg[0] <= 50 or gw_data_source_info.seg[1] - options.end <= 50:
+ raise ValueError("Check your inputted --start / --end or your frame file. You should have a long enough data such that, the --start/--end is larger/less than the start/end of your data at least 50s. ")
# Setting up PSD
if options.reference_psd:
--
GitLab