Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
gstlal
gstlal
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 19
    • Issues 19
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 0
    • Merge Requests 0
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • lscsoft
  • gstlalgstlal
  • Issues
  • #40

Closed
Open
Opened Jan 10, 2020 by Cody Messick@cody.messickMaintainer

Make on-the-fly ranking statistic assignment logic more clear

Currently, the StreamThinca class will only assign ranking statistic values if "cluster" is set to true. Long term I think we need to figure out a way to assign lrs to all of the candidates in the online running mode, not just the highest snr candidate. But until then, there should at least be comments explaining that this is the behavior. You can see in [1] that a dictionary is populated if cluster is set to True, and then the objects contained in that dictionary are assigned ranking statistics a few lines down.

https://git.ligo.org/lscsoft/gstlal/blob/6cdb742c68e895c4db5d64a5ebe1f33f209dbd0e/gstlal-inspiral/python/streamthinca.py#L311

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: lscsoft/gstlal#40