Skip to content

far.py: fix issue in calling RankingStat with using new kwarggen function

Patrick Godwin requested to merge far_kwarggen_fix into master

This fixes two issues introduced by commit cf94c2d1:

  • Changed kwarggen to be a generator rather than return a dictionary. This appears to be the intended behavior, rather than what was implemented.
  • Changed the call to kwarggen in RankingStat.__call__() to pass in min_instruments as well. This caused an issue where the number of input arguments to kwarggen didn't match.

@chad-hanna, @kipp.cannon, could you check this and make sure it's sensible?

Edited by Patrick Godwin

Merge request reports