Skip to content
  • Leo P. Singer's avatar
    BAYESTAR internal sign convention now conforms with FINDCHIRP · 2831c3cd
    Leo P. Singer authored
    The unit test for the signal amplitude model is now much more elaborate,
    anchoring the phase convention on injecting a signal with
    XLALSimInspiralFD / XLALComputeDetAMResponse. This demonstrated that there
    was a mismatch in the signal amplitude model between the code and the
    BAYESTAR paper, which this patch corrects.
    This patch also corrects a mismatch in the autocorrelation likelihood
    between the code and the BAYESTAR paper.
    The *default* phase convention for the high-level interface is still
    anti-FINDCHIRP (conforming with gstlal and MBTA).
    Fixes #2354.
    Original: 120830869b6bc8b9f2afc9684ef08b6af2cc6bfc
    2831c3cd