Truncation warning error in PulsarSimulateCoherenceGW.c
The conda builds are erroring due to a string formatting error in lalpulsar
:
CC PulsarSimulateCoherentGW.lo
../../../../lalpulsar/src/PulsarSimulateCoherentGW.c: In function 'LALPulsarSimulateCoherentGW':
../../../../lalpulsar/src/PulsarSimulateCoherentGW.c:404:9: error: '%*s' directive output may be truncated writing between 51 and 63 bytes into a region of size 52 [-Werror=format-truncation=]
if (snprintf( output->name, LALNameLength, "response to %*s", LALNameLength - 13, CWsignal->a->name ) >= LALNameLength ) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /opt/conda/envs/lal-development-py27/x86_64-conda_cos6-linux-gnu/sysroot/usr/include/stdio.h:930:0,
from /builds/duncanmmacleod/lalsuite/lalsuite-6.62.1/_build/sub/lal/include/lal/LALStdio.h:39,
from ../../../../lalpulsar/src/PulsarSimulateCoherentGW.c:21:
/opt/conda/envs/lal-development-py27/x86_64-conda_cos6-linux-gnu/sysroot/usr/include/bits/stdio2.h:65:10: note: '__builtin___snprintf_chk' output between 64 and 76 bytes into a destination of size 64
return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
__bos (__s), __fmt, __va_arg_pack ());
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CC ReadPulsarParFile.lo
CC SFTClean.lo
cc1: all warnings being treated as errors
make[6]: *** [Makefile:1137: PulsarSimulateCoherentGW.lo] Error 1
I think this was recently addressed in !963 (merged) and !965 (merged), but conda builds (gcc-7.3.0) seem to require something more to happen, I don't understand what that should be.