snprintf truncation error in lalapps/src/pulsar/HeterodyneSearch/ppe_readdata.c
gcc 8.3.0 on my new Debian Buster laptop finds another string length issue that not even the nightly pipeline has picked up so far, this time in lalapps/src/pulsar/HeterodyneSearch/ppe_readdata.c . Should be easy to fix, @matthew-pitkin could you have a look please?
make[8]: Entering directory '/home/dkeitel/git/lvc/lalsuite/lalapps/src/pulsar/HeterodyneSearch'
CC heterodyne_pulsar.o
CC create_pulsar_signal_frame.o
CC SpectralInterpolation.o
CC ppe_models.o
CC ppe_likelihood.o
CC ppe_testing.o
CC ppe_init.o
CC ppe_utils.o
CC ppe_inject.o
CC ppe_roq.o
CC ppe_readdata.o
CC pulsar_frequency_evolution.o
CC pulsar_parameter_estimation_nested.o
CC ssbtodetector.o
ppe_readdata.c: In function ‘read_pulsar_data’:
ppe_readdata.c:563:55: error: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 8 [-Werror=format-truncation=]
snprintf(ifodata->name, sizeof(char)*DETNAMELEN, "%s", dets[FACTOR(i,ml)]);
^~
ppe_readdata.c:563:5: note: ‘snprintf’ output between 1 and 256 bytes into a destination of size 8
snprintf(ifodata->name, sizeof(char)*DETNAMELEN, "%s", dets[FACTOR(i,ml)]);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CCLD lalapps_create_pulsar_signal_frame
CCLD lalapps_ssbtodetector
cc1: all warnings being treated as errors
make[8]: *** [Makefile:956: ppe_readdata.o] Error 1