SFT constraints startTime/endTime help string confusion (half-open interval convention)
XLALCWGPSinRange implements a half-open interval policy, i.e. it returns a non-success "1" ("GPS time is 'above' the range") for maxGPS==minGPS.
But according to the help of lalapps_ComputePSD:
-s, --startTime=<8-byte real> [default: 0]
GPS timestamp of earliest SFT to include
-e, --endTime=<8-byte real> [default: 0]
GPS timestamp of last SFT to include (NOTE: this refers to
the SFT start-time!)
Hence, I'd expect I should be able to call it with --startTime=startTime --endTime=
startTime and get the PSD of a single SFT - not so, because of the half-interval convention. Instead, "endTime" here really does not only not mean the intuitive "end of last SFT", but it's not even "start of last SFT", it's more like "earliest time to no longer accept as start of an SFT"...
Suggested rewording from @karl-wette by e-mail:
-s, --startTime=<8-byte real> [default: 0]
SFT timestamps must be >= this GPS timestamp
-e, --endTime=<8-byte real> [default: 0]
SFT timestamps must be < this GPS timestamp
I'll do this in the big ComputePSD MR; but this issue is supposed to be a reminder to check for similar help string confusions in other lalapps executables.