unused variables in PhenomPTest.c and SphHarmTSTest.c
@sebastian-khan @maria.haney I've noticed that recent pipelines all just "pass with warnings", specifically the conda integration test has compiler complaints in two waveform test codes, see e.g. output copied from this run below. These may soon become errors in other compilers too and lead to actual disruption.
PhenomPTest.c has @michael.puerrer identified as the lead author, while Chris Pankow for SphHarmTSTest.c has left so somebody else would need to look at that one.
PhenomPTest.c: In function 'Test_alpha_epsilon':
PhenomPTest.c:195:15: error: unused variable 'eps' [-Werror=unused-variable]
195 | const REAL8 eps = 1e-5;
| ^~~
PhenomPTest.c: In function 'Test_XLALSimIMRPhenomPCalculateModelParameters':
PhenomPTest.c:258:15: error: unused variable 'eps' [-Werror=unused-variable]
258 | const REAL8 eps = 1e-5;
| ^~~
PhenomPTest.c: In function 'Test_XLALSimIMRPhenomP':
PhenomPTest.c:479:15: error: unused variable 'eps' [-Werror=unused-variable]
479 | const REAL8 eps = 1e-5;
| ^~~
PhenomPTest.c:478:13: error: unused variable 'hc_expected' [-Werror=unused-variable]
478 | COMPLEX16 hc_expected = 2.6046e-23 + I * 5.17592e-23;
| ^~~~~~~~~~~
PhenomPTest.c:477:13: error: unused variable 'hp_expected' [-Werror=unused-variable]
477 | COMPLEX16 hp_expected = -5.17642e-23 + I * 2.60463e-23;
| ^~~~~~~~~~~
PhenomPTest.c: In function 'Test_XLALSimIMRPhenomP_f_ref':
PhenomPTest.c:758:15: error: unused variable 'eps' [-Werror=unused-variable]
758 | const REAL8 eps = 1e-5;
| ^~~
CC NSBHPropertiesTest.o
CC PNCoefficients.o
CC PrecessWaveformEOBNRTest.o
CC PrecessWaveformIMRPhenomBTest.o
CC PrecessWaveformTest.o
CC SphHarmTSTest.o
CC WaveformFlagsTest.o
SphHarmTSTest.c: In function 'main':
SphHarmTSTest.c:94:18: error: unused variable 'tdata_hlm' [-Werror=unused-variable]
94 | REAL8Sequence *tdata_hlm = XLALSphHarmTimeSeriesGetTData( ts );
| ^~~~~~~~~
CC WaveformFromCacheTest.o