Skip to content

Intermittant LALBurst test failures on Python3 build

We are seeing intermittent LALBurst test failures in the Python3 build of the form:

**********************************************************************
File "/home/ram/git/lalsuite/lalburst/python/lalburst/snglcoinc.py", line ?, in lalburst.snglcoinc.CoincRates.all_instrument_combos
Failed example:
    coincrates.all_instrument_combos
Expected:
    (frozenset(['V1']), frozenset(['H1']), frozenset(['L1']), frozenset(['V1', 'H1']), frozenset(['V1', 'L1']), frozenset(['H1', 'L1']), frozenset(['V1', 'H1', 'L1']))
Got:
    (frozenset({'V1'}), frozenset({'H1'}), frozenset({'L1'}), frozenset({'V1', 'H1'}), frozenset({'V1', 'L1'}), frozenset({'H1', 'L1'}), frozenset({'V1', 'H1', 'L1'}))
**********************************************************************
File "/home/ram/git/lalsuite/lalburst/python/lalburst/snglcoinc.py", line ?, in lalburst.snglcoinc.CoincRates.all_instrument_combos
    (frozenset(['V1']), frozenset(['H1']), frozenset(['L1']), frozenset(['V1', 'H1']), frozenset(['V1', 'L1']), frozenset(['H1', 'L1']), frozenset(['V1', 'H1', 'L1']))
Got:
    (frozenset({'V1'}), frozenset({'H1'}), frozenset({'L1'}), frozenset({'V1', 'H1'}), frozenset({'V1', 'L1'}), frozenset({'H1', 'L1'}), frozenset({'V1', 'H1', 'L1'}))
**********************************************************************
File "/home/ram/git/lalsuite/lalburst/python/lalburst/snglcoinc.py", line ?, in lalburst.snglcoinc.CoincRates.all_instrument_combos
Failed example:
    coincrates.all_instrument_combos
Expected:
    (frozenset(['V1', 'H1']), frozenset(['V1', 'L1']), frozenset(['H1', 'L1']), frozenset(['V1', 'H1', 'L1']))
Got:
    (frozenset({'V1', 'H1'}), frozenset({'V1', 'L1'}), frozenset({'H1', 'L1'}), frozenset({'V1', 'H1', 'L1'}))
**********************************************************************
File "/home/ram/git/lalsuite/lalburst/python/lalburst/snglcoinc.py", line 1067, in lalburst.snglcoinc.CoincRates.coinc_rates
Failed example:
    coincrates.coinc_rates(H1 = 0.001, L1 = 0.002, V1 = 0.003)
Expected:
    {frozenset(['V1', 'H1']): 1.9372787960306537e-07, frozenset(['V1', 'H1', 'L1']): 1.0125819710267318e-11, frozenset(['H1', 'L1']): 6.00513846088957e-08, frozenset(['V1', 'L1']): 3.77380092200718e-07}
Got:
    {frozenset({'V1', 'L1'}): 3.77380092200718e-07, frozenset({'H1', 'L1'}): 6.00513846088957e-08, frozenset({'V1', 'H1', 'L1'}): 1.0125819710267318e-11, frozenset({'V1', 'H1'}): 1.9372787960306537e-07}
**********************************************************************
File "/home/ram/git/lalsuite/lalburst/python/lalburst/snglcoinc.py", line 1069, in lalburst.snglcoinc.CoincRates.coinc_rates
Failed example:
    coincrates.coinc_rates(H1 = 0.001, L1 = 0.002, V1 = 0.002)
Expected:
    {frozenset(['V1', 'H1']): 1.291519197353769e-07, frozenset(['V1', 'H1', 'L1']): 6.750546473511545e-12, frozenset(['H1', 'L1']): 6.00513846088957e-08, frozenset(['V1', 'L1']): 2.5158672813381197e-07}
Got:
    {frozenset({'V1', 'L1'}): 2.5158672813381197e-07, frozenset({'H1', 'L1'}): 6.00513846088957e-08, frozenset({'V1', 'H1', 'L1'}): 6.750546473511545e-12, frozenset({'V1', 'H1'}): 1.291519197353769e-07}
**********************************************************************
File "/home/ram/git/lalsuite/lalburst/python/lalburst/snglcoinc.py", line 1071, in lalburst.snglcoinc.CoincRates.coinc_rates
Failed example:
    coincrates.coinc_rates(H1 = 0.001, L1 = 0.002, V1 = 0.001)
Expected:
    {frozenset(['V1', 'H1']): 6.457595986768845e-08, frozenset(['V1', 'H1', 'L1']): 3.3752732367557724e-12, frozenset(['H1', 'L1']): 6.00513846088957e-08, frozenset(['V1', 'L1']): 1.2579336406690598e-07}
Got:
    {frozenset({'V1', 'L1'}): 1.2579336406690598e-07, frozenset({'H1', 'L1'}): 6.00513846088957e-08, frozenset({'V1', 'H1', 'L1'}): 3.3752732367557724e-12, frozenset({'V1', 'H1'}): 6.457595986768845e-08}
**********************************************************************
File "/home/ram/git/lalsuite/lalburst/python/lalburst/snglcoinc.py", line 1184, in lalburst.snglcoinc.CoincRates.lnP_instruments
Failed example:
    coincrates.lnP_instruments(H1 = 0.001, L1 = 0.002, V1 = 0.003)
Expected:
    {frozenset(['V1', 'H1']): -1.181124067253893, frozenset(['V1', 'H1', 'L1']): -11.040192999777876, frozenset(['H1', 'L1']): -2.352494317162074, frozenset(['V1', 'L1']): -0.5143002401188091}
Got:
    {frozenset({'V1', 'L1'}): -0.5143002401188091, frozenset({'H1', 'L1'}): -2.352494317162074, frozenset({'V1', 'H1', 'L1'}): -11.040192999777876, frozenset({'V1', 'H1'}): -1.181124067253893}
**********************************************************************
File "/home/ram/git/lalsuite/lalburst/python/lalburst/snglcoinc.py", line 1121, in lalburst.snglcoinc.CoincRates.strict_coinc_rates
Failed example:
    coincrates.strict_coinc_rates(H1 = 0.001, L1 = 0.002, V1 = 0.003)
Expected:
    {frozenset(['V1', 'H1']): 1.937177537833551e-07, frozenset(['V1', 'H1', 'L1']): 1.0125819710267318e-11, frozenset(['H1', 'L1']): 6.004125878918543e-08, frozenset(['V1', 'L1']): 3.7736996638100773e-07}
Got:
    {frozenset({'V1', 'L1'}): 3.7736996638100773e-07, frozenset({'H1', 'L1'}): 6.004125878918543e-08, frozenset({'V1', 'H1', 'L1'}): 1.0125819710267318e-11, frozenset({'V1', 'H1'}): 1.937177537833551e-07}
**********************************************************************
File "/home/ram/git/lalsuite/lalburst/python/lalburst/snglcoinc.py", line 1123, in lalburst.snglcoinc.CoincRates.strict_coinc_rates
Failed example:
    coincrates.strict_coinc_rates(H1 = 0.001, L1 = 0.002, V1 = 0.002)
Expected:
    {frozenset(['V1', 'H1']): 1.2914516918890337e-07, frozenset(['V1', 'H1', 'L1']): 6.750546473511545e-12, frozenset(['H1', 'L1']): 6.004463406242219e-08, frozenset(['V1', 'L1']): 2.5157997758733847e-07}
Got:
    {frozenset({'V1', 'L1'}): 2.5157997758733847e-07, frozenset({'H1', 'L1'}): 6.004463406242219e-08, frozenset({'V1', 'H1', 'L1'}): 6.750546473511545e-12, frozenset({'V1', 'H1'}): 1.2914516918890337e-07}
**********************************************************************
File "/home/ram/git/lalsuite/lalburst/python/lalburst/snglcoinc.py", line 1125, in lalburst.snglcoinc.CoincRates.strict_coinc_rates
Failed example:
    coincrates.strict_coinc_rates(H1 = 0.001, L1 = 0.002, V1 = 0.001)
Expected:
    {frozenset(['V1', 'H1']): 6.457258459445168e-08, frozenset(['V1', 'H1', 'L1']): 3.3752732367557724e-12, frozenset(['H1', 'L1']): 6.004800933565894e-08, frozenset(['V1', 'L1']): 1.2578998879366924e-07}
Got:
    {frozenset({'V1', 'L1'}): 1.2578998879366924e-07, frozenset({'H1', 'L1'}): 6.004800933565894e-08, frozenset({'V1', 'H1', 'L1'}): 3.3752732367557724e-12, frozenset({'V1', 'H1'}): 6.457258459445168e-08}
**********************************************************************
File "/home/ram/git/lalsuite/lalburst/python/lalburst/snglcoinc.py", line 1511, in lalburst.snglcoinc.InstrumentBins
Failed example:
    x.centres()[55]
Expected:
    frozenset(['H1', 'L1'])
Got:
    frozenset({'H1', 'L1'})
**********************************************************************
5 items had failures:
   2 of   4 in lalburst.snglcoinc.CoincRates.all_instrument_combos
   3 of   4 in lalburst.snglcoinc.CoincRates.coinc_rates
   1 of   2 in lalburst.snglcoinc.CoincRates.lnP_instruments
   3 of   4 in lalburst.snglcoinc.CoincRates.strict_coinc_rates
   1 of   3 in lalburst.snglcoinc.InstrumentBins
***Test Failed*** 10 failures.
FAIL snglcoinc_verify.py (exit status: 1)

It seems that there are a couple of issues:

  1. The dictionaries are using different braces, the test is expecting [] but {} are being returned.
  2. The content of the dictionaries is the same, the order is just different.

This intermittent failure is delaying development. As this is only currently effecting Python3 I'm going to modify the python3 nightly build so that is doesn't cause the entire pipeline to fail but I would like this fixed before O3.

@kipp.cannon Could you please take a look at this and see if you can figure out what's going on?