lalapps_SFTclean bug for lines wider than default --maxBins
These appear to not get cleaned at all. Expected behaviour: should clean within maxBins at least. Problem is exposed with a simple addition to the test script https://git.ligo.org/david-keitel/lalsuite/-/commit/3ab19affcf4a6010bfe50f0133609716c4055b01 resulting in 0 cleaning where actually all bins of the test SFTs should be changed.
What the ages-old docs say:
There is also a width parameter. This is an upper limit on the number of bins that will be cleaned on either wing. Thus, if width is specified to say 3, then only a maximum 3 bins will be cleaned on either side irrespective of the actual wing size specified. This parameter is present for historical reasons, and should probably be removed. Currently, it is recommended to set this sufficiently large (larger that any wing size in bins) so that it has no effect.
A workaround is to just set --maxBins
high enough, but note that for narrow-band SFTs, it even has to be larger than the line width, even if setting it equal to the number of bins actually in the SFTs, still no cleaning will happen.
A clean solution would be to remove this "historical" parameter, but it also appears that the claim in the third sentence is simply not true at the moment.