Follow-up from "convert ID columns from ilwd:char to int_8s"

The following discussion from !644 (merged) should be addressed:

• @john-veitch started a discussion: (+1 comment)

  A question about this change: Using the igwn-py38 conda env, and running the command lalapps_inspinj --gps-start-time 1171214320 --gps-end-time 1171214350 --f-lower 20.000000 --waveform IMRPhenomPv2pseudoFourPN --time-step 1.000000e+00 --fixed-mass1 36.000000 --fixed-mass2 29.000000 --l-distr fixed --longitude -1.288843e+00 --latitude 8.107952e-01 --m-distr fixMasses --i-distr fixed --d-distr uniform --min-distance 1000 --max-distance 1000000 --fixed-inc 0.1 --disable-spin I see that the resulting XML file still has the datatype ilwd:char for the simulation_id column. As far as I could tell there is no change required to lalapps/src/inspiral/inspinj to pick up these changes. Is it possible that the release of lalapps has somehow not seen the change in this merge request? I am using

  (igwn-py38) john@athena:~$ lalapps_version
  LAL: 7.1.2 (CLEAN c21902de2364e911fab0c5fa47ea5b954fbced73)
  LALFrame: 1.5.4 (CLEAN e912ea74207506dd14bfe092016f3b253fbac984)
  LALMetaIO: 2.0.2 (CLEAN 3e213a2342fd1bce03380418ca1d51d51130d7c8)
  LALSimulation: 2.5.1 (CLEAN bdbbfabd0f14ce7fcb8d574f1a07e911e62c85b5)
  LALBurst: 1.5.8 (CLEAN 2062d7b514d0ebab1f013813869549a63013a0cc)
  LALInspiral: 2.0.2 (CLEAN 8ebae7ea1ab6a6d9979719b686229ce208de3817)
  LALPulsar: 3.0.1 (CLEAN dcb6fc1a2091a9d3cf76ceb505650dc6f9a48e05)
  LALInference: 2.0.7 (CLEAN 88e54127665efae9aa65495c92feee39df2ef2af)
  LALApps: 7.2.0 (CLEAN 981ff709aa365ccdd5ed1b46b8fe71e96788ca60)

  igwn-py38-testing shows the same result.

  @adam-mercer @kipp.cannon can you shed any light on this? CC @sudarshan-ghonge

The problem is that LIGOLwXMLlegacy.c needs to be updated to match the new format.