MFDv5 --noiseSFTs buggy after interval convention change
@karl-wette Followup to !1728 (merged): Caught by the PyFstat CI (-> https://github.com/PyFstat/PyFstat/issues/377 ): calling MFDv5 with --noiseSFTs
and without explicit --Band
option, we end up with one missing SFT bin at the end, i.e. even one less than expected from the "open interval" policy.
This seems to not get caught by the LALSuite test suite because in the command with --noiseSFTs (https://git.ligo.org/lscsoft/lalsuite/-/blob/master/lalapps/src/pulsar/MakeData/testMakefakedata_v5.sh#L235) we inherit the base CL from https://git.ligo.org/lscsoft/lalsuite/-/blob/master/lalapps/src/pulsar/MakeData/testMakefakedata_v5.sh#L212 which contains explicit --fmin=$fmin --Band=$Band
options, overriding the inconsistent behaviour.
Simplified test example, the expected output is [29.75,30.25)
at delta_freq=1/1800=0.000555556, which is achieved correctly for test1 and test3 but not for test2:
lalapps_Makefakedata_v5 --outSingleSFT=TRUE --outSFTdir="TestData" --outLabel="test1" --IFOs="H1" --sqrtSX="1" --SFTWindowType="tukey" --SFTWindowBeta=0.001 --startTime=700000000 --duration=1800 --fmin=29.75 --Band=0.5 --Tsft=1800 --randSeed=69420
lalapps_dumpSFT -i TestData/H-1_H1_1800SFT_test1-700000000-1800.sft | tail -n 1
30.249444444 1.122181e+01 -9.019400e-01
lalapps_Makefakedata_v5 --outSingleSFT=TRUE --outSFTdir="TestData" --outLabel="test2" --noiseSFTs="TestData/H-1_H1_1800SFT_test1-700000000-1800.sft" --SFTWindowType="tukey" --SFTWindowBeta=0.001
lalapps_dumpSFT -i TestData/H-1_H1_1800SFT_test2-700000000-1800.sft | tail -n 1
30.248888889 2.519729e+01 3.247344e+01
lalapps_Makefakedata_v5 --outSingleSFT=TRUE --outSFTdir="TestData" --outLabel="test3" --noiseSFTs="TestData/H-1_H1_1800SFT_test1-700000000-1800.sft" --SFTWindowType="tukey" --SFTWindowBeta=0.001 --fmin=29.75 --Band=0.5
lalapps_dumpSFT -i TestData/H-1_H1_1800SFT_test3-700000000-1800.sft | tail -n 1
30.249444444 1.122181e+01 -9.019400e-01
I'll open an MR to expose the problem in the test suite but might not be able to return to it very quickly; maybe if you have a chance for a quick fix, you could add it right to that branch.